Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(clippy): fix all new clippy errors with 'rustc:1.73.0' #111

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

woshilapin
Copy link
Contributor

Description

Rust had a few new versions since the last CI job had run. Since clippy is launched with --deny warnings and new lints have been implemented since, there is few errors that any new CI job will trigger. This PR fixes all new errors due to clippy:1.73.0.

Motivation and Context

Working on #110, the CI was failing for reasons unrelated to the PR.

How Has This Been Tested?

No change of functionality, just running clippy should be enough (and the CI takes care of that).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other : only stylistic changes

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation and changelog accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Rustfmt and Rust-clippy passed.

Also updating `proc-macro2` because of rust-lang/rust#113152
makes the build fail on nightly.
@woshilapin
Copy link
Contributor Author

I'm not sure what's happening on the CI, I'm not able to reproduce on my machine on nightly. However, thanks to the log, I've seen rust-lang/rust#113152 and therefore, updated proc-macro2. Let's see if this helps.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@orhun orhun merged commit 6182434 into orhun:master Oct 27, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants