Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0.2] Gif recording won't work on Arch Linux #12

Closed
DistantThunder opened this issue Dec 8, 2020 · 5 comments
Closed

[1.0.2] Gif recording won't work on Arch Linux #12

DistantThunder opened this issue Dec 8, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@DistantThunder
Copy link

DistantThunder commented Dec 8, 2020

Describe the bug
Recording does not work

To Reproduce
Steps to reproduce the behavior:

  1. Run menyoki record rec gif
  2. See error

Expected behavior
The recording begins?

Screenshots/Logs

[2020-12-08T19:24:31 INFO menyoki::x11::window] Starting in 3[2020-12-08T19:24:31 INFO menyoki::util::command] Running the command...
thread 'main' panicked at 'Failed to run the command: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/app.rs:212:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
fish : Tâche , 'LANG=C menyoki record rec gif' terminée par le signal SIGABRT (Abandon)

System Information

  • OS: Arch Linux x86_64 5.9.9-arch1-1
  • Rust Version: 1.48.0
  • Project Version: 1.0.2

Additional context
N/A

@DistantThunder DistantThunder added the bug Something isn't working label Dec 8, 2020
@orhun
Copy link
Owner

orhun commented Dec 8, 2020

1. Run `record rec gif` parameters

Try menyoki rec gif.

Edit: What are the exact parameters that you're using to run menyoki?

@DistantThunder
Copy link
Author

Oh, I was misusing them, with the correct command it works. Sorry for the trouble.

I'm trying to use it together with slop so that I can use it in a CLI-less style, but I've to figure out how to start the recording after selection is done.

@orhun
Copy link
Owner

orhun commented Dec 8, 2020

Oh, I was misusing them, with the correct command it works. Sorry for the trouble.

No worries 👍🏼

I'm trying to use it together with slop so that I can use it in a CLI-less style, but I've to figure out how to start the recording after selection is done.

menyoki record --root --size $(slop)

You have to press record key bindings after slop selection is done basically. I could've implement without it but it contradicts with my design choice.

Also about the Failed to run the command message, menyoki can run a command and record/capture it's output. So it probably thought one of your misused arguments was a command and tried to run it.

@DistantThunder
Copy link
Author

You have to press record key bindings after slop selection is done basically. I could've implement without it but it contradicts with my design choice.

Alright thanks. I can't help but think it'd be nice to have a flag to start right away as it would allow powerful workflow by just mapping menyoki to a something like Ctrl-PrintScr, selecting the area you want to record and then you're done. But indeed without any kind of feedback, the user is a bit blind to what's happening behind the scene and this kind of workflow typically calls for some kind of visual feedback which may not be the project scope.

Thank you for taking your time to develop this and answer to annoying users!

@orhun
Copy link
Owner

orhun commented Dec 10, 2020

Okay I changed the default behaviour a little bit:

menyoki cap --root --size $(slop)

I

And if you still want to confirm the selection with action keys (LAlt-S), use --select:

II

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants