Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for copying captures and videos #19

Merged
merged 3 commits into from
Mar 8, 2021
Merged

Add examples for copying captures and videos #19

merged 3 commits into from
Mar 8, 2021

Conversation

ribosomerocker
Copy link
Contributor

Description

Added two examples to the capture and record commands, my editor also stripped some spaces after the lines automatically, and I made tables more consistent.

Motivation and Context

It was added to ease beginners into using this, and to show how to use the save subcommand's "-" option in conjunction with xclip.

How Has This Been Tested?

using cargo test goes fine, but using cargo test --features test-ws produces two errors:

test x11::window::tests::test_x11_window ... FAILED
test x11::tests::test_x11_system ... FAILED

I haven't exactly changed anything in the other code, so I'm not sure

After running those two commands:

cargo fmt --all -- --check --verbose
cargo clippy --verbose -- -D warnings

Everything seems to work except for one thing:

    Checking menyoki v1.2.1 (/home/mon/Git/menyoki)
     Running `/home/mon/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/clippy-driver rustc --crate-name menyoki --edition=2018 src/main.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,metadata -C opt-level=2 -C panic=abort -C embed-bitcode=no -C debuginfo=2 -C debug-assertions=on --cfg 'feature="default"' --cfg 'feature="gifski"' --cfg 'feature="imgref"' --cfg 'feature="rgb"' --cfg 'feature="ski"' -C metadata=74d57682c096c4a4 -C extra-filename=-74d57682c096c4a4 --out-dir /home/mon/Git/menyoki/target/debug/deps -C incremental=/home/mon/Git/menyoki/target/debug/incremental -L dependency=/home/mon/Git/menyoki/target/debug/deps --extern apng=/home/mon/Git/menyoki/target/debug/deps/libapng-8bc66a0bfd5baaf5.rmeta --extern bytesize=/home/mon/Git/menyoki/target/debug/deps/libbytesize-24920a379a7d3f04.rmeta --extern chrono=/home/mon/Git/menyoki/target/debug/deps/libchrono-3b7e79d4cc7b3d13.rmeta --extern clap=/home/mon/Git/menyoki/target/debug/deps/libclap-700fd43089bddce9.rmeta --extern colored=/home/mon/Git/menyoki/target/debug/deps/libcolored-2ae8420037ebcd63.rmeta --extern ctrlc=/home/mon/Git/menyoki/target/debug/deps/libctrlc-d159e976f2904a7a.rmeta --extern device_query=/home/mon/Git/menyoki/target/debug/deps/libdevice_query-0e39ec43acc02b0e.rmeta --extern dirs=/home/mon/Git/menyoki/target/debug/deps/libdirs-013c81d28a994e97.rmeta --extern dominant_color=/home/mon/Git/menyoki/target/debug/deps/libdominant_color-bab85d5cfc3b6e77.rmeta --extern fern_colored=/home/mon/Git/menyoki/target/debug/deps/libfern_colored-6e3ddffdba8a1142.rmeta --extern gif=/home/mon/Git/menyoki/target/debug/deps/libgif-4e5e110f2cd51696.rmeta --extern gifski=/home/mon/Git/menyoki/target/debug/deps/libgifski-48c2ff52bf1a10de.rmeta --extern hex=/home/mon/Git/menyoki/target/debug/deps/libhex-1224e69de6972fd1.rmeta --extern image=/home/mon/Git/menyoki/target/debug/deps/libimage-759c3c821d2825a2.rmeta --extern imgref=/home/mon/Git/menyoki/target/debug/deps/libimgref-9fc7f8f8819e700c.rmeta --extern exif=/home/mon/Git/menyoki/target/debug/deps/libexif-cde206a5cc55d0b0.rmeta --extern log=/home/mon/Git/menyoki/target/debug/deps/liblog-04c3ff028bf49915.rmeta --extern natord=/home/mon/Git/menyoki/target/debug/deps/libnatord-d2f7798d7ebd474c.rmeta --extern png=/home/mon/Git/menyoki/target/debug/deps/libpng-4a9c30e0737a9403.rmeta --extern rgb=/home/mon/Git/menyoki/target/debug/deps/librgb-9dee233c713ece2e.rmeta --extern ini=/home/mon/Git/menyoki/target/debug/deps/libini-231a6254d380dc7e.rmeta --extern x11=/home/mon/Git/menyoki/target/debug/deps/libx11-64a4b415bdea17f1.rmeta -L native=/usr/lib -L native=/usr/lib -L native=/home/mon/Git/menyoki/target/debug/build/imagequant-sys-90e7f4c8b1b44d0a/out`
error: This sequence of operators looks suspiciously like a bug.
   --> src/settings.rs:161:32
    |
161 |                 if geometry.height == 0 || geometry.height > ico_geometry.width {
    |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: I think you meant: `geometry.height > ico_geometry.height`
    |
    = note: `-D clippy::suspicious-operation-groupings` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_operation_groupings

error: aborting due to previous error

error: could not compile `menyoki`

Caused by:
  process didn't exit successfully: `/home/mon/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/clippy-driver rustc --crate-name menyoki --edition=2018 src/main.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type bin --emit=dep-info,metadata -C opt-level=2 -C panic=abort -C embed-bitcode=no -C debuginfo=2 -C debug-assertions=on --cfg 'feature="default"' --cfg 'feature="gifski"' --cfg 'feature="imgref"' --cfg 'feature="rgb"' --cfg 'feature="ski"' -C metadata=74d57682c096c4a4 -C extra-filename=-74d57682c096c4a4 --out-dir /home/mon/Git/menyoki/target/debug/deps -C incremental=/home/mon/Git/menyoki/target/debug/incremental -L dependency=/home/mon/Git/menyoki/target/debug/deps --extern apng=/home/mon/Git/menyoki/target/debug/deps/libapng-8bc66a0bfd5baaf5.rmeta --extern bytesize=/home/mon/Git/menyoki/target/debug/deps/libbytesize-24920a379a7d3f04.rmeta --extern chrono=/home/mon/Git/menyoki/target/debug/deps/libchrono-3b7e79d4cc7b3d13.rmeta --extern clap=/home/mon/Git/menyoki/target/debug/deps/libclap-700fd43089bddce9.rmeta --extern colored=/home/mon/Git/menyoki/target/debug/deps/libcolored-2ae8420037ebcd63.rmeta --extern ctrlc=/home/mon/Git/menyoki/target/debug/deps/libctrlc-d159e976f2904a7a.rmeta --extern device_query=/home/mon/Git/menyoki/target/debug/deps/libdevice_query-0e39ec43acc02b0e.rmeta --extern dirs=/home/mon/Git/menyoki/target/debug/deps/libdirs-013c81d28a994e97.rmeta --extern dominant_color=/home/mon/Git/menyoki/target/debug/deps/libdominant_color-bab85d5cfc3b6e77.rmeta --extern fern_colored=/home/mon/Git/menyoki/target/debug/deps/libfern_colored-6e3ddffdba8a1142.rmeta --extern gif=/home/mon/Git/menyoki/target/debug/deps/libgif-4e5e110f2cd51696.rmeta --extern gifski=/home/mon/Git/menyoki/target/debug/deps/libgifski-48c2ff52bf1a10de.rmeta --extern hex=/home/mon/Git/menyoki/target/debug/deps/libhex-1224e69de6972fd1.rmeta --extern image=/home/mon/Git/menyoki/target/debug/deps/libimage-759c3c821d2825a2.rmeta --extern imgref=/home/mon/Git/menyoki/target/debug/deps/libimgref-9fc7f8f8819e700c.rmeta --extern exif=/home/mon/Git/menyoki/target/debug/deps/libexif-cde206a5cc55d0b0.rmeta --extern log=/home/mon/Git/menyoki/target/debug/deps/liblog-04c3ff028bf49915.rmeta --extern natord=/home/mon/Git/menyoki/target/debug/deps/libnatord-d2f7798d7ebd474c.rmeta --extern png=/home/mon/Git/menyoki/target/debug/deps/libpng-4a9c30e0737a9403.rmeta --extern rgb=/home/mon/Git/menyoki/target/debug/deps/librgb-9dee233c713ece2e.rmeta --extern ini=/home/mon/Git/menyoki/target/debug/deps/libini-231a6254d380dc7e.rmeta --extern x11=/home/mon/Git/menyoki/target/debug/deps/libx11-64a4b415bdea17f1.rmeta -L native=/usr/lib -L native=/usr/lib -L native=/home/mon/Git/menyoki/target/debug/build/imagequant-sys-90e7f4c8b1b44d0a/out` (exit code: 1)

I'm not really sure about this, neither

Types of changes

  • 馃悰 Bug fix (non-breaking change which fixes an issue)
  • 馃尡 New feature (non-breaking change which adds functionality)
  • 馃尩 Breaking change (fix or feature that would cause existing functionality to change)
  • 馃摎 Documentation (no code change)
  • 馃Ч Refactor (refactoring production code)
  • 鈿欙笍 Other

Checklist:

  • [] 馃帹 My code follows the code style of this project.
  • 馃摎 I have updated the documentation accordingly.
  • 馃搻 I have formatted the code with rustfmt.
  • 馃搳 I have added tests to cover my changes.
  • 馃搱 All new and existing tests passed.
  • 馃搸 Clippy is not complaining.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@orhun orhun merged commit a17de09 into orhun:master Mar 8, 2021
orhun added a commit that referenced this pull request Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants