-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 tests fail on git master #253
Comments
The file Unfortunately the rustypaste logo is 224,372 bytes while the Example jpg is currently 25,503 bytes. I'll think of something. |
Ok, so all your PNGs in your repos are around 200-250k. Wikipedia does not have permanent links, but they archived the previous one and this link should never change. |
Sounds good to me! |
Small problem. for some reason the hash even changed for the old file (different link, but same file). I suspect that the |
I'm thinking if we should just remove those tests altogether or gate them behind a feature flag. They have been failing spuriously for some time. |
Which tests? all of the ones in Btw, I have the fix for the same filename ready. Just waiting for the other PR to be merged, because the file op would then require an One more thing: it seems that the auto-merge for the depandabot PRs doesn't work. Neither here, nor in the cli repo. |
I meant only the ones that require fetching stuff from a remote server (i.e. Wikipedia) - but I guess they are fine.
Do you think we should have Mergify? What do you think of auto-merging PRs? |
Ah, ok. Yep, they should be fine now. Well, it's always a risk, e.g. if there's a connection issue from the runner, which happens now and then.
It's setup in rustypaste-cli, but doesn't seem to work.
Complex topic. It entails a certain risk, although in can be minimized. If the automerge only happens, if all tests pass successfully, then it should be fine. If there's also a way to limit it to minor and patch upgrades, it's even better. P.S.: I am only talking about dependabot PRs. |
Yeah, fair point. I think I will set up auto merging again soon. Can you shoot me an issue so that I don't forget? 🙏🏼 |
Steps to reproduce:
This is what I get on macOS and on Linux:
The text was updated successfully, but these errors were encountered: