Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(upload): update the hash of the example file #254

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Mar 6, 2024

Description

The file https://upload.wikimedia.org/wikipedia/en/a/a9/Example.jpg was replaced by a different version on March 1st.

I checked, the old file still exists and the hash is the same, but unfortunately the util::sha256_digest seems to take the filename into account, because I tried to replace the link, but the hash changed in the rustypaste tests as well. When I check the hash on the commandline with shasum, it's actually the same though.

Since the hash changes either way, I just updated the hash, instead of link and hash.

Motivation and Context

fixes #253

How Has This Been Tested?

cargo test
fixtures

Changelog Entry

### Fixed

- update hash in tests, since the file changed at source

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tessus tessus requested a review from orhun as a code owner March 6, 2024 04:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.42%. Comparing base (db971e6) to head (c6b4a41).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   70.88%   70.42%   -0.46%     
==========================================
  Files          11       11              
  Lines         625      629       +4     
==========================================
  Hits          443      443              
- Misses        182      186       +4     
Flag Coverage Δ
unit-tests 70.42% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun
Copy link
Owner

orhun commented Mar 6, 2024

It's fun to see wikipedia getting updated

@orhun orhun changed the title test: update hash of file (changed at source) test(upload): update the hash of the example file Mar 6, 2024
@orhun orhun merged commit fa5105d into orhun:master Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 tests fail on git master
3 participants