Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tui): improve the termion panic hook #169

Merged
merged 3 commits into from Apr 5, 2024

Conversation

eld4niz
Copy link
Contributor

@eld4niz eld4niz commented Apr 4, 2024

Description

Termion error handler does not work correctly with current version, so we decided that to rewrite it within orhun/kmon#141 and implemented the same for systeroid-tui.

Motivation and Context

#168

How Has This Been Tested?

I put panic!() to the lib.rs to generate panic and test if terminal will be messed up or not.

Screenshots / Logs (if applicable)

image

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eld4niz eld4niz requested a review from orhun as a code owner April 4, 2024 13:16
systeroid-tui/src/main.rs Outdated Show resolved Hide resolved
systeroid-tui/src/main.rs Outdated Show resolved Hide resolved
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun changed the title bug: update termion panic hook refactor(tui): improve the termion panic hook Apr 5, 2024
@orhun orhun merged commit dd51d17 into orhun:main Apr 5, 2024
8 of 14 checks passed
@eld4niz eld4niz deleted the panic_handler branch April 6, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants