Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃憣 IMPROVE] Makefile: .PHONY #8

Merged
merged 2 commits into from Nov 1, 2019
Merged

[馃憣 IMPROVE] Makefile: .PHONY #8

merged 2 commits into from Nov 1, 2019

Conversation

andrei-pavel
Copy link
Contributor

Without the build rule added to .PHONY, when running make sequentially, it alternatively runs build + clean and only clean. The second time, it sees that the build directory is already built so it skips it, like in the screenshot:

image

Might as well add all the other rules to .PHONY.

@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #8   +/-   ##
======================================
  Coverage    95.9%   95.9%           
======================================
  Files           1       1           
  Lines         122     122           
======================================
  Hits          117     117           
  Misses          5       5

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ebf5ad9...0ebd836. Read the comment docs.

@andrei-pavel
Copy link
Contributor Author

Would you be willing to leave the default compiler alone? Something like:

ifeq ($(CC),)
    CC:=gcc
endif

I like to compile with clang for example 馃槥

I can include this change in this pull request.

@orhun
Copy link
Owner

orhun commented Oct 31, 2019

It would be good if you include the compiler option in this pull request. The reason why I've added the gcc alone was it is kind of a standard compiler. But like you said, it is much better if Makefile supports other options.
Other changes are also okay.

* use default CC if provided
* add -Wextra and -pedantic flags
@orhun orhun merged commit eff4b9f into orhun:master Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants