Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[馃悰 FIX] warnings #9

Merged
merged 4 commits into from Nov 2, 2019
Merged

[馃悰 FIX] warnings #9

merged 4 commits into from Nov 2, 2019

Conversation

andrei-pavel
Copy link
Contributor

  • signed/unsigned comparisons
  • superfluous casts
  • cast unused parameters to void
  • implicit fallthrough
  • no newline at end of file

[馃悰 FIX] warnings
01dab97 
* signed/unsigned comparisons
* superfluous casts
* cast unused parameters to void
* implicit fallthrough
* no newline at end of file
@codecov-io
Copy link

codecov-io commented Nov 1, 2019 •
edited

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master      #9   +/-   ##
======================================
  Coverage    95.9%   95.9%           
======================================
  Files           1       1           
  Lines         122     122           
======================================
  Hits          117     117           
  Misses          5       5
Impacted Files Coverage 螖
src/zps.c 95.9% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ebf5ad9...6888004. Read the comment docs.

@orhun
Copy link
Owner

orhun commented Nov 1, 2019

Using fallthrough is necessary for -l and -r arguments to work as expected. I'm not saying it's a good practice but it's running normally with fallthough right now.
Other changes seem OK but I can't merge this pull request until I refactor parseArgs function.

Andrei Pavel added 3 commits November 2, 2019 10:15
@andrei-pavel
Copy link
Contributor Author

This is amazing. gcc recognizes the // fall through comment and if spelled exactly like that, it silences the comment. clang doesn't complain to start with.

Sorry, I saw -l said list and -r said don't list and I thought they step on each other's toes.

@andrei-pavel
Copy link
Contributor Author

Thank you for creating this! 馃 馃

@orhun
Copy link
Owner

orhun commented Nov 2, 2019

Thanks for your contribution! :octocat:

@orhun orhun merged commit 5ee2239 into orhun:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrei-pavel @codecov-io @orhun