Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Client=55) Log for OCommandExecutionException shouldn't shorten bad query #3296

Closed
garrettg123 opened this issue Dec 29, 2014 · 0 comments
Closed
Assignees
Milestone

Comments

@garrettg123
Copy link

The query should not be shortened in logs. What's the point of a log that replaces the error in a query with ...?

For example, in this query there is a NumberFormatException. Where? This log is useless for debugging:

Sent run-time exception to the client /127.0.0.1:53271: com.orientechnologies.orient.core.exception.OCommandExecutionException: Error on execution of command: sql.BEGIN
 LET vertex-0 = CREATE vertex Workout SET targetDuration = 30, goal = 1, level = 2, location = 3, equipment = [2,11,4], muscles = [], addons = [1,2], isBuilding = true, name = "Speedy Total Pump...
com.orientechnologies.orient.core.exception.OCommandExecutionException: Error on execution of command: sql.BEGIN
 LET vertex-0 = CREATE vertex Workout SET targetDuration = 30, goal = 1, level = 2, location = 3, equipment = [2,11,4], muscles = [], addons = [1,2], isBuilding = true, name = "Speedy Total Pump...
  at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.executeCommand(OAbstractPaginatedStorage.java:1178)
  at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.command(OAbstractPaginatedStorage.java:1161)
  at com.orientechnologies.orient.core.command.OCommandRequestTextAbstract.execute(OCommandRequestTextAbstract.java:63)
  at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.command(ONetworkProtocolBinary.java:1179)
  at com.orientechnologies.orient.server.network.protocol.binary.ONetworkProtocolBinary.executeRequest(ONetworkProtocolBinary.java:385)
  at com.orientechnologies.orient.server.network.protocol.binary.OBinaryNetworkProtocolAbstract.execute(OBinaryNetworkProtocolAbstract.java:216)
  at com.orientechnologies.common.thread.OSoftThread.run(OSoftThread.java:65)
Caused by: java.lang.NumberFormatException: For input string: "null"
  at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
  at java.lang.Integer.parseInt(Integer.java:580)
  at java.lang.Integer.parseInt(Integer.java:615)
  at com.orientechnologies.orient.core.id.ORecordId.fromString(ORecordId.java:262)
  at com.orientechnologies.orient.core.id.ORecordId.<init>(ORecordId.java:61)
  at com.orientechnologies.orient.core.sql.OSQLHelper.parseValue(OSQLHelper.java:127)
  at com.orientechnologies.orient.core.sql.OSQLHelper.parseValue(OSQLHelper.java:94)
  at com.orientechnologies.orient.core.sql.OSQLHelper.parseValue(OSQLHelper.java:193)
  at com.orientechnologies.orient.core.sql.OCommandExecutorSQLSetAware.getFieldValueCountingParameters(OCommandExecutorSQLSetAware.java:69)
  at com.orientechnologies.orient.core.sql.OCommandExecutorSQLSetAware.parseSetFields(OCommandExecutorSQLSetAware.java:58)
  at com.orientechnologies.orient.graph.sql.OCommandExecutorSQLCreateVertex.parse(OCommandExecutorSQLCreateVertex.java:74)
  at com.orientechnologies.orient.graph.sql.OCommandExecutorSQLCreateVertex.parse(OCommandExecutorSQLCreateVertex.java:49)
  at com.orientechnologies.orient.core.sql.OCommandExecutorSQLDelegate.parse(OCommandExecutorSQLDelegate.java:56)
  at com.orientechnologies.orient.core.sql.OCommandExecutorSQLDelegate.parse(OCommandExecutorSQLDelegate.java:37)
  at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.command(OAbstractPaginatedStorage.java:1159)
  at com.orientechnologies.orient.core.command.OCommandRequestTextAbstract.execute(OCommandRequestTextAbstract.java:63)
  at com.orientechnologies.orient.core.command.script.OCommandExecutorScript.executeSQLScript(OCommandExecutorScript.java:192)
  at com.orientechnologies.orient.core.command.script.OCommandExecutorScript.executeSQL(OCommandExecutorScript.java:138)
  at com.orientechnologies.orient.core.command.script.OCommandExecutorScript.executeInContext(OCommandExecutorScript.java:82)
  at com.orientechnologies.orient.core.command.script.OCommandExecutorScript.execute(OCommandExecutorScript.java:73)
  at com.orientechnologies.orient.core.storage.impl.local.OAbstractPaginatedStorage.executeCommand(OAbstractPaginatedStorage.java:1172)
  ... 6 more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants