OPartitionedDatabasePoolFactory returns a closed pool

[raeesn]

Sample code :

           OPartitionedDatabasePoolFactory poolFactory = new OPartitionedDatabasePoolFactory();
    OPartitionedDatabasePool pool = poolFactory.get("plocal:testdb", "administrator", "administrator");
    ODatabaseDocumentTx db = pool.acquire();
    db.close();
    pool.close();

After closing the pool, in the later stage of application; getting the pool from the same factory and trying to acquire a new connection reports "Pool is closed"

   java.lang.IllegalStateException: Pool is closed
at com.orientechnologies.orient.core.db.OPartitionedDatabasePool.checkForClose(OPartitionedDatabasePool.java:373)
at com.orientechnologies.orient.core.db.OPartitionedDatabasePool.acquire(OPartitionedDatabasePool.java:238)

The OPartitionedDatabasePoolFactory retains the pool instance and returns the same, which was closed, as PoolIdentity is same.

[lvca]

You should close the pool factory at the end of your application.

[andrii0lomakin]

Guys can not agree issue is still relevant.

[andrii0lomakin]

It is not needed usually to close pool at all, but if users closes it, we should do not use it any more.

[andrii0lomakin]

Fixed