(docs) Some suggestions re Task docs #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-calleja
commented
Mar 27, 2017
docs/source/en/data/task/index.md
Outdated
|
|
||
| if (someAsyncPredicate(...)) { | ||
| ... | ||
| } | ||
|
|
||
| Since `someAsyncPredicate` never returns any value, but instead passes it as an argument to another function. | ||
| Since `someAsyncPredicate`, instead of returning a value, passes the result of its computation to another function (the callback). |
There was a problem hiding this comment.
Come to think of it:
"Instead of returning a value, someAsyncPredicate passes the result..."
would flow better. Feel free to change this in your branch if you want to :)
robotlolita
force-pushed
the
patch/task-docs
branch
from
43cf9f8
to
251f5aa
Compare
robotlolita
added a commit
that referenced
this pull request
Apr 9, 2017
ghost
assigned
robotlolita
added a commit
that referenced
this pull request
Apr 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some suggested changes - I know it's still WIP