Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the animators object in the animator cells on refresh #69

Closed
originalnicodr opened this issue Apr 10, 2024 · 1 comment
Closed
Assignees
Labels
animator Anything related to the Animator panel feature bug Something isn't working

Comments

@originalnicodr
Copy link
Owner

Describe the issue

When refreshing the animator's list in the Animator Panel we don't refresh cells from entities that are already there. Unfortunately, this means that if these entities had their list of animation list updated inside the game, then we wouldn't update them in the dropdown.

So we should update the Unity animator object inside the wrapper and the dropdown, or just delete all cells in the list.

@originalnicodr originalnicodr added bug Something isn't working animator Anything related to the Animator panel feature labels Apr 10, 2024
@originalnicodr originalnicodr self-assigned this Apr 10, 2024
@originalnicodr
Copy link
Owner Author

Solved in 171ee3f by instead appending new animations to the existing ones. That way we let the user have an even bigger list of animations to choose from if they update it at the right moment.

Maybe we can mock the property in the future to automatically detect when new animations are added so we can add them to our existing list of animation clips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
animator Anything related to the Animator panel feature bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant