-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New FB reported Fail: nested components #11
Comments
The solution is to decompose the nested components? |
Yes, it would be the case. Component referring to another component are not exported correctly to the ttf variable format. They take back the coordinates of the original glyph. E.g. Issue #2961 Once you decompose them, please ensure they don't end up fractional coordinates also. These verifications are related to our Outline Quality Checklist. |
I have decomposed mark characters (such as .case and vietnamese diacritics) that were build as components and built new fonts but the report of FB test says there's still a lot of nested components left but it doesnt give the full list of characters. Is there a way to have FB print the full list of characters with nested components in them? You can see the report in the the branch
The fontfile Kufam-Regular.ttf gives an error on almost every test with this ERROR message: 💥 ../Fonts/TTF/Kufam-Regular.ttf |
I uploaded to my QA-Kufam branch a list of nested or transformed components made with one local script in progress. |
The decomposing of nested components has quite an impact on the benefits of using components during the editing stage. It would mean to rebuild quite some characters if the base shape is changed. Would it be better to address this in the build script as post-processing? Another question is which component should be decomposed? |
…d-components Attempt to fix Issue #11 Nested components
I'm opening this issue again because of this result. @vv-monsalve Are there other options for un-nesting nested components without touching the source files? |
This Fail was reported after performing new 0.7.34 FB version tests on latest font files in the repo, at commit 49b9656
🔥 FAIL: Check glyphs do not have components which are themselves components.
The text was updated successfully, but these errors were encountered: