Diffenator report Italics

[vv-monsalve]

These are the main differences reported by Diffenator. Please review all of them and ensure everything is working as expected.

Black Italic

Bold Italic

SemiBold Italic

[vv-monsalve]

[vv-monsalve]

Although this was expected, please ensure there are all of the desired glyphs, 890 are reported as new.

[arturschmal]

@vv-monsalve Apart from the merging of the Arabic set into the italic source file, I can not explain the other differences as as nothing in the source files that affects this has been touched. Quite some of the characters reported seem to be the characters that have nested components. Could it be that the un-nesting in build.sh causes positional shifts?

[vv-monsalve]

Could it be that the un-nesting in build.sh causes positional shifts?

If after inspecting the source file it's confirmed nothing else has changed, then the two facts could be related.

It would be needed to run the build.sh without the -f flag to confirm.

[arturschmal]

I compared source files from master with source files in decompose-nested-transformed-components with MergeGlyphs and it shows only the changes that are known to me. So apart from outline and kerning issues that I fixed the source files are identical.

I ran build.sh without the -f flag and then ran gftools qa -f Kufam-BlackItalic.ttf -gfb -a -o qa.
There's still quite some characters indicated as different, but the shifting of the nested components before and after is not there anymore. So -f does seem to affect component positioning.

[simoncozens]

If there is a difference being caused by the -f flag, that would be a bug in ufo2ft. I'm happy to investigate but would need a bit more information.

If we can produce a small test case (just delete all irrelevant glyphs from the .glyphs file to leave one or two affected glyphs and the components they use), that would be helpful for debugging.

[vv-monsalve]

Thanks, Simon. I'm attaching a file with a few glyphs.
Kufam_few-glyphs.zip

[simoncozens]

I can't see a difference. :-/

I had to delete a few more glyphs to make the fonts compile (missing components, deleted glyphs referenced in features features, etc.) My version attached.

$ fontmake -g Kufam_few-glyphs.glyphs -o ttf; mv master_ttf/Kufam-BlackItalic.ttf master_ttf/Kufam-BlackItalic-NonFlat.ttf
$ fontmake -f -g Kufam_few-glyphs.glyphs -o ttf; mv master_ttf/Kufam-BlackItalic.ttf master_ttf/Kufam-BlackItalic-Flat.ttf
$ shape shape master_ttf/Kufam-BlackItalic-Flat.ttf 'Ẫ'
[uni1EAA=0+736]

$ shape master_ttf/Kufam-BlackItalic-NonFlat.ttf 'Ẫ'
[uni1EAA=0+736]

Kufam_few-glyphs-SC.zip

[arturschmal]

Hi Simon, thanks for doing this test. There is a slight vertical shift visible of the accents. You can see that in the flat version the accent has shifted down, closer towards the cap height.

[simoncozens]

Yes, I see it now! Thanks! (Not a designer...)

Will investigate what’s happening. It’s obviously some ufo2ft thing.

[simoncozens]

OK, this is actually fixed in the ufo2ft master repository, but no releases have been made yet. If you want to run bleeding-edge ufo2ft, then add this to your requirements file:

git+https://github.com/googlefonts/ufo2ft

Also run pip3 install -U git+https://github.com/googlefonts/ufo2ft to use the latest version on your local computer.

[vv-monsalve]

Thanks! I'll try it and let you know

[vv-monsalve]

I've pulled the latest files on the repo at commit 5790686, installed the latest version of ufo2ft, created new fonts and performed new checks.
These are the new Diffenator reports for modified glyphs. For better comparison, here are the same images as in the previous comment

Black Italic

Bold Italic

SemiBold Italic

Despite they are reported as modified (probably for the flattened components) I don't see any difference now on them, so I would say the -f flag is working.

There are other changes reported but regarding other things, like me base glyphs in the GDEF, so I'll report them in other Issues or comments.

Also, I'm attaching here the complete Diffenator report folder so that @arturschmal can inspect it in detail.

qaKufam-Diffenator4.zip

[vv-monsalve]

Hi @arturschmal, this is the Diffenator report after pulling the latest files in the repo at commit d7d8753

Black Italic

Bold Italic

SemiBold