Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round export button in infowindow #1530

Merged
merged 3 commits into from
Jun 17, 2022

Conversation

asemoller
Copy link
Contributor

Closes #1220.

Makes it possible to have round exports button when "infowindow": "infowindow".
This PR also includes a change to the simpleExport structure in the json file.

Config for clientExport with text button, simpleExport with new structure and round button and layerSpecificExport with round button:

"clientExport": {
   "format": "geojson",
   "buttonText" : "Exportera fil",
   "layers": [ "lager_1", lager_2" ],
   "button": {
      "buttonText": "Exportera fil",
      "roundButton": false
   }
},
"simpleExport": {
   "url": "xxx/origoserver/excelcreator",
   "layers": [ "lager_1" ],
   "button": {
      "roundButton": true,
      "roundButtonIcon": "#fa-download",
      "roundButtonTooltipText": "Ladda ner excelfil"
      }
 },
"layerSpecificExport": [{
   "layer": "lager_2",
   "attributesToSendToExport": ["name"],
   "exportUrls":[{
      "url": "xxx",
      "exportedFileName": "filename_1.xlsx",
      "button": {
         "roundButton": true,
         "roundButtonIcon": "img/png/export_knapp_excel.png",
         "roundButtonTooltipText": "Ladda ner excelfil"
         }
      }]
  }]

We think it's cleaner to have the same structure for all the export functions. Please note that these changes doesn't work with old json files.

If we need to make an issue for restructuring the simpleExport, please let us know.

@jokd
Copy link
Contributor

jokd commented Jun 1, 2022

@asemoller Is it possible for you to solve the conflicts and then I'll merge this?

@asemoller
Copy link
Contributor Author

Has probably something to do with the spinner and that's above my level 😃. I can give it a try though!

@asemoller
Copy link
Contributor Author

I can resolve the conflicts but there's a css problem with the spinner that I don't know how to fix 😞!

@jokd
Copy link
Contributor

jokd commented Jun 17, 2022

LGTM

@jokd jokd merged commit c311381 into origo-map:master Jun 17, 2022
@asemoller asemoller deleted the origo-master-iw-round-icons-pr branch June 17, 2022 17:02
@asemoller asemoller restored the origo-master-iw-round-icons-pr branch March 8, 2023 15:47
@asemoller asemoller deleted the origo-master-iw-round-icons-pr branch June 20, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infowindow - round export buttons
3 participants