Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: let img attribute have precedence before name #1775

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix: let img attribute have precedence before name #1775

merged 2 commits into from
Jun 15, 2023

Conversation

johnnyblasta
Copy link
Collaborator

Fixes #1774

Test config:

        {
          "img": "bild",
          "name": "bild",
          "title": "Bild: ",
          "type": "image"
        }

@steff-o
Copy link
Contributor

steff-o commented May 31, 2023

Why not put name last? That would fix the other attribute types as well.

@johnnyblasta
Copy link
Collaborator Author

Why not put name last? That would fix the other attribute types as well.

Yeah, thought about that also after I sent in the PR.

@johnnyblasta
Copy link
Collaborator Author

Moved name to last in getting attributes to let all special case have precedence over the general case.

@johnnyblasta johnnyblasta merged commit 09bf026 into master Jun 15, 2023
@johnnyblasta johnnyblasta deleted the editor-image branch June 15, 2023 10:48
@steff-o steff-o mentioned this pull request Aug 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokd jokd jokd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image and editor can't coexist img attribute
3 participants
@johnnyblasta @steff-o @jokd