Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrote the infowindow export #1782

Merged
merged 3 commits into from
Jun 20, 2023
Merged

fix: rewrote the infowindow export #1782

merged 3 commits into from
Jun 20, 2023

Conversation

jokd
Copy link
Contributor

@jokd jokd commented Jun 14, 2023

Fixes #1711 #1746 #1781
Merged parts of infowindow and infowindow_expandableList
Fixes round buttons in list view
simpleExport works for all layers if omitted in config

@asemoller
Copy link
Contributor

@jokd Wow, I set this up for us to fix after the holidays but you're super fast 👍 . Nice that you put everything in exporthandler.js. I'll test and get back!

@asemoller
Copy link
Contributor

I've only tested it locally and this is what I found (new and old ones 🙂):

If the layer property for clientExport is omitted like this "layers": [], the button (round or text button) is not displayed. However, it works fine for simpleExport now.

Default text for text buttons is "Export" for server-side exports and "Exportera" for clientExport. For round buttons the default text is "Ladda ner" for both server side and client exports. Maybe they all should have "Ladda ner" as default text, regardless of button.

If "roundButton": true for simpleExport, the property for "roundButtonTooltipText" doesn't work.

If "listLayout": true then there's some css-problems:

  • lower left corner lacks rounding
  • if the tooltipText is too long it will not be displayed outside the window.

This is really a great fix! We're so grateful for this contribution 🙏 !

@asemoller
Copy link
Contributor

I just realized that I never tested omitted layer just by removing the layer property for clientExport! If I do that, it works fine for clientExport 🙂.

@jokd
Copy link
Contributor Author

jokd commented Jun 16, 2023

I just realized that I never tested omitted layer just by removing the layer property for clientExport! If I do that, it works fine for clientExport 🙂.

Now it should both without layers but also an empty array. And hopefully the rest of your comments should be solved.
The easiest way to show the tooltips without messing too much with css or rearranging the elements is to show the tooltip to the right so I just changed the direction.

@asemoller
Copy link
Contributor

Yes, everything seems to work now 👍!

@jokd jokd merged commit d7966ef into master Jun 20, 2023
@jokd jokd deleted the infowindow-exports branch June 20, 2023 10:49
asemoller pushed a commit to SigtunaGIS/origo that referenced this pull request Jul 17, 2023
* Merged part of the infowindows

* Added defaults

* Update _infowindow.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants