feature: spinner for print map loading indicator #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright I had some local feedback and instead of the prior wispy thing the current incarnation has some gravitas: |
jokd
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion for an indicator in addition to tiles appearing at the edges of the print map and the two print buttons being greyed out that the print map is loading. Aims to fix #1871
It looks like the larger "global" print spinner that shows when printing -> png and shows in the middle of the print map preview, more directly tied to the map not being finished that way I thought.
Draft pr less because I think it needs anything else and more because it may need to be something different. There are various ways of implementing a spinner or progress bar. As for the resident options in Origo, the "global" spinner is in a different place in the DOM (for a reason I guess) and has logic for that purpose (well looks rather). The "progress" control doesn't take configuration presently and is purposed as a singleton of the main map. The "spinner in utils/ appears a bit visually unappealing.