Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make it possible to have more backgroud layers #1985

Merged
merged 12 commits into from
Mar 27, 2024

Conversation

huggla
Copy link
Contributor

@huggla huggla commented Mar 25, 2024

Makes the background layer buttons wrap. #1981
bild

Make background layer icons wrap.
@Grammostola
Copy link
Contributor

Grammostola commented Mar 25, 2024

Hi, nicely done. In the case of a legend control with the following prop:

        "contentStyle": {
          "width": "350px"
        }

then the show active layers and minimize legend buttons should probably be situated in the bottom right, like where they are without a multirow of background map buttons?

image

@huggla
Copy link
Contributor Author

huggla commented Mar 26, 2024

Thanks for your feedback. I have fixed so it adapts to the legend width given.

Hi, nicely done. In the case of a legend control with the following prop:

        "contentStyle": {
          "width": "350px"
        }

then the show active layers and minimize legend buttons should probably be situated in the bottom right, like where they are without a multirow of background map buttons?

image

@huggla
Copy link
Contributor Author

huggla commented Mar 26, 2024

I've changed the look. Better?

bild

bild

@Grammostola
Copy link
Contributor

It works for me.
image

Copy link
Collaborator

@johnnyblasta johnnyblasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huggla huggla merged commit 9797691 into origo-map:master Mar 27, 2024
3 checks passed
@huggla huggla mentioned this pull request Mar 28, 2024
@huggla
Copy link
Contributor Author

huggla commented Apr 2, 2024

When I merged the original PR the hide and close buttons were perfectly aligned with the background layer buttons. But when I checked on a different computer a day later the alignment was off and I submitted a fix. Now, a few days later, the alignment is once again off by a few px. I have disabled cache in my browsers. Any ideas what causes this? Is it better to set margins in em/rem instead of px?

@tonnyandersson tonnyandersson linked an issue Apr 16, 2024 that may be closed by this pull request
@johnnyblasta johnnyblasta changed the title Make it possible to have more backgroud layers fix: make it possible to have more backgroud layers Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to have more backgroud layers
3 participants