Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backoff on connection retries #4

Closed

Conversation

vshlapakov
Copy link

The PR adds simple backoff logic to add optional delay for connection retries.

Review, please.

Review on Reviewable

@mcclymont
Copy link
Contributor

Hi. Can you please explain why you think this retry delay is needed? Did you encounter a situation where it retried very often?

If needed, I think it would be better to just include a mandatory retry delay of a few seconds rather than adding a configuration option.

@vshlapakov
Copy link
Author

Hi @mcclymont Of course, sorry for being too brief.

My usecase is a distributed system with collectd + potsdb when OpenTSDB instance can be down (due to maintenance, for example), and not having backoff on retries looks pretty harmful for the system. I don't mind if this delay will be fixed, as you wish! Usually people want to have an ability to tune everything :)

@mcclymont
Copy link
Contributor

I've implemented a simple exponential backoff instead 0fb0bbf. Released in v1.0.3. Thanks for your input.

@mcclymont mcclymont closed this Jan 25, 2016
@vshlapakov
Copy link
Author

Thanks @mcclymont!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants