Reimplement array equality check

orlandos-nl · Jun 16, 2020 · bb46957 · bb46957
1 parent 693083a
commit bb46957
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 9 deletions.
diff --git a/Sources/BSON/Document/Document+Equatable.swift b/Sources/BSON/Document/Document+Equatable.swift
@@ -10,13 +10,26 @@ extension Document: Equatable {
             return false
         }
 
-        for key in lhs.keys {
-            guard
-                let lhsValue = lhs[key],
-                let rhsValue = rhs[key],
-                lhsValue.equals(rhsValue)
-            else {
-                return false
+        if lhs.isArray {
+            for i in 0..<lhs.count {
+                let lhsValue = lhs[i]
+                let rhsValue = rhs[i]
+
+                guard
+                    lhsValue.equals(rhsValue)
+                else {
+                    return false
+                }
+            }
+        } else {
+            for key in lhs.keys {
+                guard
+                    let lhsValue = lhs[key],
+                    let rhsValue = rhs[key],
+                    lhsValue.equals(rhsValue)
+                else {
+                    return false
+                }
             }
         }
 

diff --git a/Tests/BSONTests/BSONPublicTests.swift b/Tests/BSONTests/BSONPublicTests.swift
@@ -145,10 +145,10 @@ final class BSONPublicTests: XCTestCase {
     }
 
     func testRemoveArray() throws {
-        var array: Document = ["A", "B", "C"]
+        var array: Document = ["ACXZCXZCXZZX", "BaSDASDASAS", "C"]
         XCTAssertEqual(array.values.count, 3)
         array.remove(at: 0)
-        XCTAssertEqual(array, ["B", "C"])
+        XCTAssertEqual(array, ["BaSDASDASAS", "C"])
     }
 
     func testDecodeSingleValue() throws {