Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkmate sound #1238

Closed
ddugovic opened this issue Nov 15, 2015 · 7 comments
Closed

Checkmate sound #1238

ddugovic opened this issue Nov 15, 2015 · 7 comments
Labels
improvement Small incremental improvement to an existing feature no scala non technical Artwork, content, documentation

Comments

@ddugovic
Copy link
Contributor

While looking at the final (checkmate) position of http://en.lichess.org/y7yJIqz1 , lichess audibly announces "check".

@Unihedro
Copy link
Contributor

I don't think there exists a difference between check and checkmate sounds, so that may be the problem.

@ddugovic
Copy link
Contributor Author

I was mistaken in thinking other sound sets have checkmate sounds (just "victory" sounds). If we want, I volunteer to create "checkmate" sounds (most of which will probably sound like the "victory" sounds).

@Unihedro Unihedro added improvement Small incremental improvement to an existing feature chore labels Nov 15, 2015
@Unihedro Unihedro changed the title Robot sound Check is made in checkmate position Checkmate sound Nov 15, 2015
@TheCodeArtist
Copy link

Do we need separate sounds for a checkmate victory and a opponent's clock timed-out victory?
(any other kinds of victories exist?)

@Calinou
Copy link

Calinou commented Dec 1, 2017

(any other kinds of victories exist?)

Yes, mainly victory by opponent resign.

@stale
Copy link

stale bot commented Dec 14, 2019

There has been no activity on this issue for 2 years. It will be automatically closed in 2 weeks.
If the issue is still relevant, please briefly explain (or remove the label). Feel free to reopen at any time.

@stale stale bot added the stale label Dec 14, 2019
@niklasf niklasf removed the stale label Dec 14, 2019
@Calinou
Copy link

Calinou commented Dec 14, 2019

I think it's still relevant 🙂

@niklasf niklasf added non technical Artwork, content, documentation and removed chore labels Oct 15, 2020
@ddugovic
Copy link
Contributor Author

ddugovic commented Apr 8, 2021

Sorry I dropped the ball on this (but also am no longer recommending this). Whether or not it is ever developed, in theory https://github.com/ornicar/lila/discussions seems a more productive place to discuss improvements than https://github.com/ornicar/lila/issues does.

@ddugovic ddugovic closed this as completed Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Small incremental improvement to an existing feature no scala non technical Artwork, content, documentation
Projects
None yet
Development

No branches or pull requests

5 participants