Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'check' sound to standard sound set #1896

Open
isaacl opened this issue May 22, 2016 · 5 comments
Open

Add 'check' sound to standard sound set #1896

isaacl opened this issue May 22, 2016 · 5 comments
Labels
improvement Small incremental improvement to an existing feature no scala non technical Artwork, content, documentation

Comments

@isaacl
Copy link
Member

isaacl commented May 22, 2016

The standard sounds do not have a 'check' sound, would be nice to have this to quickly tell when in check.

See also #1238
@Unihedro Unihedro added improvement Small incremental improvement to an existing feature good first issue Narrow in scope (but not necessarily easy) labels May 24, 2016
pepellou added a commit to pepellou/lila that referenced this issue Aug 20, 2017
@pepellou
Copy check sound from robot set to standard set
d502b4e 
Fixes lichess-org#1896.

As a note, I'm not sure if this solution is a matter of taste. I'm not a
sound creator, but this sound ok for me.
pepellou added a commit to pepellou/lila that referenced this issue Aug 20, 2017
@pepellou
Copy check sound from robot set to standard set
6b0a2d3 
Fixes lichess-org#1896.

As a note, I'm not sure whether this solution is a matter of taste.
I'm not a sound creator, but this sounds ok for me.
@pepellou pepellou mentioned this issue Aug 20, 2017
Closed
@TheCodeArtist
Copy link

The standard sound-set now has Check.mp3/ogg.

Is this issue ready to be closed?...

@isaacl
Copy link
Member Author

isaacl commented Dec 1, 2017

These are just silent placeholders

@TheCodeArtist
Copy link

Yup. Got it. :-) Will work on creating these sounds.

@visch visch mentioned this issue Dec 31, 2018
Closed
@visch
Copy link

visch commented Dec 31, 2018 •
edited
Loading

I think the good first issue label should be removed.

There is already sound packs in lichess. We could probably add some way to modify each of those sound packs or create your own custom sound packs with existing sounds. My ideal is Standard Plus a different Check noise (other than silent)

My workflow would look something like
Go to sounds -> Create new -> Copy from Standard -> Point the Check sound to a sound from a different sound set.

@niklasf niklasf added good first issue Narrow in scope (but not necessarily easy) no scala and removed good first issue Narrow in scope (but not necessarily easy) labels Feb 26, 2019
@niklasf niklasf added the non technical Artwork, content, documentation label Jan 7, 2020
@stale
Copy link

stale bot commented Jan 9, 2022

There has been no activity on this issue for 2 years. It will be automatically closed in 2 weeks.
If the issue is still relevant, please briefly explain (or remove the label). Feel free to reopen at any time.

@stale stale bot added the stale label Jan 9, 2022
@niklasf niklasf removed the stale label Jun 1, 2022
@niklasf niklasf mentioned this issue Mar 19, 2023
Closed
@hb20007 hb20007 mentioned this issue Jan 3, 2024
Closed
@hb20007 hb20007 mentioned this issue May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Small incremental improvement to an existing feature no scala non technical Artwork, content, documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@niklasf @isaacl @TheCodeArtist @Unihedro @visch