-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADIOS2 2.9.0 release #3569
Comments
cc: @pnorbert |
I intent to add this template to master after this release to standardize the release process PR #3570. Its the first time doing something like this thus there might be some changes here and there. |
@vicentebolea just curious, what about updating the Spack package.py? |
Thanks for pointing out, indeed, we need to add that step |
Can we also add updating the conda-feedstock recipe? |
We do treat Spack as a first citizen since it is an ECP project and help us to deploy ADIOS2 in Doe supercomputers. For other package managers, we can delegate on their community with occasional help from us. |
Thanks @vicentebolea .
There is an automated PR. Unfortunately, it's catching several test failures it might be of interest here. CC @ax3l |
On another note the Spack build is failing due to our removal of the deprecated adios_init function in both Sensei and ParaView . I will update both projects and patch the spack package so that it offers those deprecated overloads in the meanwhile. Keeping here the error message for future reference: Sensei
ParaView
@eisenhauer do you think that adding a temporary (until next releases of ParaView and maybe Sensei) patch the reverts of #3494 in Spack will be able to build? We would want to build ADIOS2 with latest release of ParaView. |
@vicentebolea on ParaView I don't know the status of the vtkCoreImageReader. I think it hasn't been maintained in a long time (hence the failure). Better to check with you and @caitlinross |
Closing this as the release has been already done. |
I am not familiar with it, maybe @caitlinross |
I don't really know much about it either, or how much it's used. I'm pretty sure it's tested in VTK CI, but I believe that uses ADIOS 2.8.x (can't remember which one), so that's why it wasn't caught that way. I think Vicente already took care of updating that in VTK. I guess we should also update VTK CI to use ADIOS 2.9 now too. And I guess ParaView superbuild? |
Sorry, I read this too fast, as @caitlinross said we already have a MR in VTK that updates it. After it makes it to VTK master it will take a while to make it to ParaView master. Thus there will be a period of time where people can potentially hit this error if building ParaView with ADIOS 2.9. For people using Spack they soon will be able to do it as soon as this PR gets merged: spack/spack#36563
Good idea lets do it soon
After the MR fixing this makes it to ParaView |
I hope this helps, as half of the failed builds seem to have trouble with a known change in multiprocessing in Python > 3.8 on OS X. |
Instructions for performing an ADIOS2 release:
./scripts/developer/create-changelog.sh v2.9.0 v2.8.3
The text was updated successfully, but these errors were encountered: