Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated bindings for release #3494

Merged
merged 2 commits into from Feb 22, 2023

Conversation

eisenhauer
Copy link
Member

No description provided.

@eisenhauer
Copy link
Member Author

@pnorbert I think we had a conversation about this last year, but I don't remember what forum (email, git, slack, etc.). However, I think this is the gist of it: At least some of the contracts tests failing here are pulling source from external repos to see if they will still compile after the commit. Those that still rely upon deprecated APIs will not compile after we remove said APIs. Some of those externals, like the adios examples, we can fix ourselves. Others require getting fixes pushed into repos of our collaborators. We probably should have been pushing to get that done as soon as we marked some things deprecated. We did not. But if we want to kill deprecated things as part of this release, we do need to sort this somehow.

Copy link
Contributor

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure they are relevant but there are some references to the debug mode in some examples/testing codes and in the documentation.

Otherwise it looks good to me.

@eisenhauer
Copy link
Member Author

Not sure they are relevant but there are some references to the debug mode in some examples/testing codes and in the documentation.

I grep'd for "debug" in the rest of the stuff, but maybe I missed things. If you have pointers, please share!

@anagainaru
Copy link
Contributor

I double checked and even though the comments refer to using debug mode, the code doesn't actually do it. Your changes are the only ones I could find as well. Your code passes the tests on my laptop.

@vicentebolea
Copy link
Collaborator

CI shows builds errors errors due to calls in some parts of the code to those newly deleted functions.

@eisenhauer
Copy link
Member Author

CI shows builds errors errors due to calls in some parts of the code to those newly deleted functions.

Anything other than what I reference in the first note above?

@vicentebolea
Copy link
Collaborator

CI shows builds errors errors due to calls in some parts of the code to those newly deleted functions.

Anything other than what I reference in the first note above?

Nope, it looks good to me :)

pnorbert
pnorbert previously approved these changes Feb 22, 2023
@pnorbert pnorbert merged commit 2c587e6 into ornladios:release_29 Feb 22, 2023
@eisenhauer eisenhauer deleted the Deprecated branch February 22, 2023 16:03
vicentebolea pushed a commit that referenced this pull request Feb 22, 2023
Remove deprecated bindings for release
@vicentebolea vicentebolea mentioned this pull request Apr 3, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants