Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin engine #215

Merged
merged 4 commits into from
Aug 18, 2017
Merged

Conversation

chuckatkins
Copy link
Contributor

No description provided.

@chuckatkins
Copy link
Contributor Author

I still need to add tests and examples, but the implementation is there now.


private:
struct Impl;
std::unique_ptr<Impl> m_Impl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind the copy constructor will get deleted implicitly due to std::unique_ptr.

@williamfgc
Copy link
Contributor

Great job! More than reviewing it, I'd like to understand the implementation once you're done. If this is real-time I'd think the bool m_DebugMode we discussed before has probably little to no benefit, and exceptions might have to be always checked. I don't know enough to evaluate, though.

@chuckatkins chuckatkins changed the title WIP: Add plugin engine Add plugin engine Aug 17, 2017
@chuckatkins chuckatkins merged commit 01377ca into ornladios:master Aug 18, 2017
@chuckatkins chuckatkins deleted the add-plugin-engine branch August 18, 2017 12:33
chuckatkins pushed a commit to chuckatkins/ADIOS2 that referenced this pull request Jan 7, 2019
Code extracted from:

    https://github.com/zeux/pugixml.git

at commit 9fcae40bb5577381a37c493a34633f7948fab208 (master).

Upstream Shortlog
-----------------

Alexander Straub (1):
      4c791586 Suffixes for different build types (ornladios#191)

Arseny Kapoulkine (38):
      951f1ed4 Add a comment to clarify subtle branch in node_copy_tree
      cb0e8937 docs: Update v1.9 release date to 04.04
      4f9af798 Work around gcc-8 warning
      cff1933e docs: Update changelog
      a3258528 tests: Fix PUGIXML_NO_STL build
      0c74e117 Update version to 1.9
      be260a09 docs: Regenerate HTML documentation
      62728d9c tests: Fix PUGIXML_NO_EXCEPTIONS tests
      5f4afe3b tests: Fix PUGIXML_NO_XPATH build
      474a4a3f tests: Fix PUGIXML_NO_XPATH,PUGIXML_COMPACT build
      8436f2a6 tests: Fix PUGIXML_COMPACT build on some platforms
      341cea5a docs: Fix changelog formatting
      55277326 Add brief license information back to README.md
      e6dde9cf scripts: Use LICENSE file in pugixml.podspec
      24a7064e Update README.md
      43b0a6a0 Clarify comment in get_strconv_attribute
      c53fdab9 Clarify comment in get_strconv_pcdata as well
      51322cff Move CMake build postfix setup behind an off-by-default USE_POSTFIX
      e584ea33 docs: Mention that node is a container of children in ranged for section
      699143c5 scripts: Set file permissions when building .zip archive
      f3139f4c Add .gitattributes file
      514478d1 Fix version comment; 190 = 1.9.0 (major.minor.patch)
      6b9c07e6 tests: Allow document_load_file_special_folder to load empty document
      cb4a74d5 Minor CMakeLists.txt cleanup
      1a96777b tests: Fix XPath denorm tests on Intel compiler
      e3b5e9ce XPath: Refactor xpath_node_set short buffer optimization
      81c82588 Work around clang --analyze warnings
      d9fadc74 XPath: Workaround Coverity false positive
      fa686f00 Update all URLs to pugixml.org to https://
      aac75cd2 Escape TAB character in attribute values with &#9;
      f9a2a7d1 Fix Wdouble-promotion warnings
      1a9c3f66 Enable config=sanitize in Travis CI
      7664bbf9 tests: Only use load_file_special_folder test on macOS
      4b57d098 Add support for MinGW builds on AppVeyor
      7d0d8ee7 Update .travis.yml
      2da15249 Add PUGIXML_WCHAR_MODE configuration to MinGW tests
      ba84465d Move unreachable line handling to Makefile
      9fcae40b Happy New Year!

Bernd Amend (1):
      12139f58 fix cmake warning "Policy CMP0048 is not set" (ornladios#214)

Bruno Pagani (1):
      61f2180d Split LICENSE to a separate file for easier distribution

Dan Lipsa (1):
      273fa0ab Remove warning in Visual Studio (ornladios#235)

Eli Schwartz (1):
      daeb8013 cmake: always install the pkg-config file (ornladios#193)

Millian Poquet (1):
      b3db08ff pkg-config: Use CMake GnuInstallDirs FULL vars

Vyacheslav Egorov (1):
      c51214f2 Visual Studio Natvis visualization (ornladios#227)

Wolfgang Stöggl (2):
      c12889f7 Use CMAKE_INSTALL_LIBDIR for pugixml.pc (ornladios#215)
      d3dd79d5 Update URL to https in pugixml.pc.in

cecilios (1):
      7d2436ec Add coverity annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants