Workaround for lammps and Scorpion to have a green CI #3502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicentebolea
changed the title
|
@pnorbert I am using your branch in your fork here to test the CI. Seems to build alright, some issues with tests. https://github.com/ornladios/ADIOS2/actions/runs/4247828013/jobs/7386477545 |
|
lammps was not built with adios. In |
vicentebolea
force-pushed
the
fix-external-ci-tests
branch
3 times, most recently
from
5856421
to
4f270c3
Compare
vicentebolea
force-pushed
the
fix-external-ci-tests
branch
from
4f270c3
to
a05510c
Compare
vicentebolea
changed the title
|
@pnorbert can you review this PR. THanks :) |
pnorbert
approved these changes
Feb 24, 2023
vicentebolea
added a commit
that referenced
this pull request
Feb 24, 2023
Workaround for lammps and Scorpion to have a green CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup: #3494
While the Lammps and Scorpio applications are being updated to drop the Adios2 deprecated functions, we need to make some changes to keep our CI green. This MR:
their code to our current API.