Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I3454 missing mpi functions in doc #3558

Conversation

dmitry-ganyushin
Copy link
Contributor

Corrected Doxyfile.

@eisenhauer
Copy link
Member

Target for release_29?

@eisenhauer
Copy link
Member

There may be some confusion between ADIOS2_HAVE_X and ADIOS2_USE_X because there's some differences in meaning internally and externally. In building ADIOS, ADIOS2_USE_X is used to control whether or not we should use X in the build and mostly controls CMake. I.E. if ADIOS2_USE_X is set to ON, CMake looks for X and it's an error if it doesn't find it. If set to Auto it looks for X and it's not an error if it doesn't find it. If set to Off, it doesn't look for X. Then ADIOS2_HAVE_X is set to true if USE was ON or AUTO AND the thing was found. So in the core code, I think we should be generally looking at HAVE_X, not USE_X. However, the bindings are a bit different. There we expect the user to define ADIOS2_USE_X if they want to build with/use a version of ADIOS that was built with X. So, we can have conditionals in the bindings that look at, for example ADIOS2_USE_MPI, where we probably don't want to do that in core code. I think this was different originally and perhaps Chuck formalized that distinction. That change, and spots where it was missed, is probably the source of this problem, and it would probably be wise for us to maybe do a quick audit to see if there are other places where this isn't properly done.

@anagainaru anagainaru changed the base branch from master to release_29 March 24, 2023 00:25
@dmitry-ganyushin dmitry-ganyushin force-pushed the i3454-missing-mpi-functions-in-doc branch from 815573d to bcadea1 Compare March 25, 2023 01:26
@dmitry-ganyushin dmitry-ganyushin self-assigned this Mar 27, 2023
eisenhauer
eisenhauer previously approved these changes Mar 28, 2023
@vicentebolea vicentebolea added this to the v2.9.0 milestone Mar 28, 2023
@eisenhauer eisenhauer merged commit 92e0eb1 into ornladios:release_29 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants