TestBPChangingShapeWithinStep without and with various compressors #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
previously approved these changes
Apr 6, 2023
pnorbert
changed the title
|
New test now works with blosc, mgard and zfp (CPU-only) if they are available. |
|
I did not dismiss your review, nor requested new review. Was automatic somehow |
Yes I am in the codeowner file for the cmake files. I think I have to limit it so I am not asked to review everywhere haha. It was good during the release but not needed anymore |
anagainaru
previously approved these changes
Apr 7, 2023
pnorbert
force-pushed
the
test-changing-shape-blosc2
branch
from
231c82d
to
3c8cffa
Compare
|
rebased with master |
pnorbert
force-pushed
the
test-changing-shape-blosc2
branch
from
47ec16c
to
56b94d8
Compare
|
Cleaned-up the commit history after fixing the build on windows. Ready for review and merge after passing the tests. |
pnorbert
force-pushed
the
test-changing-shape-blosc2
branch
from
56b94d8
to
99dc7e0
Compare
anagainaru
approved these changes
Apr 10, 2023
…ressors to it if they are available (blosc, mgard, zfp). Tests: Engine.BP.*/BPChangingShapeWithinStep.MultiBlock/*.
pnorbert
force-pushed
the
test-changing-shape-blosc2
branch
from
99dc7e0
to
8bbdefa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on turned on. This is an openPMD use case that needs to be checked.