Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SYCL support to the Kokkos backend #3621

Merged
merged 4 commits into from
May 18, 2023

Conversation

anagainaru
Copy link
Contributor

@anagainaru anagainaru commented May 13, 2023

Adding the SYCL backend in ADIOS2 (tested on ALCF Polaris with oneapi and clang++)

This was also tested with the new build system that Vicente is pushing in #3623

One change that affects the other backends is that long double will no longer be supported for metadata computation (min/max) since it is not supported by several configurations I tried running on.

@anagainaru anagainaru changed the title [WIP] Adding the SYCL to the Kokkos backend Adding the SYCL to the Kokkos backend May 17, 2023
@anagainaru anagainaru marked this pull request as ready for review May 17, 2023 15:09
@anagainaru
Copy link
Contributor Author

This is ready for review

@masterleinad let me know if you have any comments on the SYCL specific functions

@anagainaru anagainaru changed the title Adding the SYCL to the Kokkos backend Adding SYCL support to the Kokkos backend May 17, 2023
source/adios2/helper/adiosKokkos.cpp Outdated Show resolved Hide resolved
source/adios2/helper/adiosKokkos.cpp Outdated Show resolved Hide resolved
@vicentebolea
Copy link
Collaborator

@anagainaru this looks good, but in principle I would skip it for the patch release since this is not a bugfix. Is there a reason of why would you need this in the next patch release?

@anagainaru
Copy link
Contributor Author

@vicentebolea you are right, I will rebase it over master
Should I wait until you merge your PR #3623?

@vicentebolea
Copy link
Collaborator

Should I wait until you merge your PR #3623?

That makes sense to wait for the rebase, the CI should pass in less then 1h.

@vicentebolea
Copy link
Collaborator

@anagainaru #3623 was merged to master

@anagainaru anagainaru changed the base branch from release_29 to master May 17, 2023 19:10
@anagainaru
Copy link
Contributor Author

Rebased and ready to be reviewed one last time

Copy link
Contributor

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

Copy link
Collaborator

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good refactor there

@anagainaru anagainaru merged commit 2aace5f into ornladios:master May 18, 2023
32 checks passed
@anagainaru anagainaru deleted the sycl-backend branch November 18, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants