Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use nvcc_wrapper in adiosKokkos #3623

Merged
merged 2 commits into from May 17, 2023

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented May 16, 2023

fixes #3566

Taken from the comment added in the changes

  # Kokkos imposes us to set our CMAKE_CXX_COMPILER to Kokkos_CXX_COMPILER.
  # The problem is that we do not want this for the whole project and with
  # CMake we cannot set the CXX_COMPILER for a single target. The solution is
  # to move the adios2 module that uses Kokkos to its independent subdir and
  # set there CMAKE_CXX_COMPILER, which is possible (and scoped to that subdir)
  # in cmake.

@vicentebolea vicentebolea force-pushed the kokkos-use-nvcc-wrapper branch 2 times, most recently from 7cfe742 to b893ba2 Compare May 16, 2023 18:35
@vicentebolea
Copy link
Collaborator Author

@anagainaru

@vicentebolea vicentebolea force-pushed the kokkos-use-nvcc-wrapper branch 8 times, most recently from bc39c5a to 1b8541e Compare May 16, 2023 20:54
@vicentebolea vicentebolea marked this pull request as ready for review May 16, 2023 21:04
@vicentebolea vicentebolea added this to the v2.10.0 milestone May 16, 2023
@vicentebolea vicentebolea self-assigned this May 16, 2023
Copy link
Contributor

@anagainaru anagainaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vicente for working on this. I will test this on Summit/Perlmutter/Crusher and come back to update the review

CODEOWNERS Outdated Show resolved Hide resolved
cmake/DetectOptions.cmake Outdated Show resolved Hide resolved
cmake/DetectOptions.cmake Outdated Show resolved Hide resolved
source/adios2/helper/kokkos/CMakeLists.txt Show resolved Hide resolved
@anagainaru
Copy link
Contributor

anagainaru commented May 17, 2023

Screenshot 2023-05-17 at 8 03 10 AM

I tested the new script on the three systems and it seems to work everywhere ! Perlmutter with gcc 11.2 and cuda 11.7 gives some errors for Kokkos 3.7 but works starting with the patch on (it was giving the same error before this PR, I just didn't test with the vanilla 3.7 until now). Once we converge in the find_package we can merge this.

@vicentebolea
Copy link
Collaborator Author

@anagainaru fantastic work there checking where it builds/runs 👍 👍 👍

@anagainaru
Copy link
Contributor

I realized that now we can always use g++ to build ADIOS2 and the Kokkos parts will use whatever we use to build Kokkos. I updated the HIP script.

@vicentebolea vicentebolea merged commit 189f384 into ornladios:master May 17, 2023
35 checks passed
@vicentebolea vicentebolea deleted the kokkos-use-nvcc-wrapper branch May 29, 2023 21:07
vicentebolea added a commit to vicentebolea/ADIOS2 that referenced this pull request May 29, 2023
…rapper

ci: use nvcc_wrapper in adiosKokkos
(cherry picked from commit 189f384)
vicentebolea added a commit that referenced this pull request Jul 3, 2023
* release_29:
  Allow Span in files opened for Append
  crusher,ci: set unique env per pipeline
  fixed #3638
  CI,windows: change MSMPI URL
  Bump requests from 2.28.1 to 2.31.0 in /docs
  docs: update whatsnew
  ci,crusher: minor tweaks
  ci,olcf,crusher: enable Crusher CI
  ci,ascent: enable ascent builds
  Merge pull request #3623 from vicentebolea/kokkos-use-nvcc-wrapper
  BP5: fixes memory error with IBM XL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADIOS2 GPU-aware breaks with Kokkos 4.0
2 participants