Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add mgard dependency to spack builds #3753

Merged
merged 4 commits into from Aug 17, 2023

Conversation

vicentebolea
Copy link
Collaborator

@vicentebolea vicentebolea commented Aug 11, 2023

Closes #3752

  • It adds MGARD as a dependency.
  • Since it requires a recent (but not too recent) MGARD it uses a newer E4S release.
  • It fixes a static build issue with duplicated symbols from our pugixml dependency.
  • It adds a way to add non-adios2 dependencies to our spack builds.
  • It disable Serial tests in MPI builds that have an equivalent dedicated Serial build.
  • It removed some OMPI tweaks that breaks newer OMPI.

@vicentebolea vicentebolea force-pushed the add-mgard-to-ci branch 6 times, most recently from 4249c77 to 4479eda Compare August 14, 2023 17:58
@vicentebolea vicentebolea force-pushed the add-mgard-to-ci branch 2 times, most recently from ed31400 to 7dca7f6 Compare August 14, 2023 18:33
@vicentebolea
Copy link
Collaborator Author

@scottwittenburg

Copy link
Collaborator

@scottwittenburg scottwittenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Now that you are the first one to change the E4S base image for the ubuntu builds, can you comment on:

  • Did you build with --progress=plain or similar to see how the buildcache hit rate was affected?
  • Is the time to build and push all the images affected much?
  • Did the size of the resulting images change much?

You'll have to push again to get rid of the tmp in the image tags everywhere. I forget if, in this project, that will dismiss my review. Just ping me if you need me to re-approve after pushing.

@vicentebolea vicentebolea merged commit c8d87b0 into ornladios:master Aug 17, 2023
31 checks passed
@vicentebolea vicentebolea deleted the add-mgard-to-ci branch August 17, 2023 00:24
@vicentebolea
Copy link
Collaborator Author

This all looks good to me. Now that you are the first one to change the E4S base image for the ubuntu builds, can you comment on:

* Did you build with `--progress=plain` or similar to see how the buildcache hit rate was affected?

* Is the time to build and push all the images affected much?

* Did the size of the resulting images change much?

You'll have to push again to get rid of the tmp in the image tags everywhere. I forget if, in this project, that will dismiss my review. Just ping me if you need me to re-approve after pushing.

Oh, I had the auto-merge enabled for this and it merged before renaming the tags.

I will follow up in another MR and report the information asked by you

@vicentebolea
Copy link
Collaborator Author

followup #3768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MGARD to CI
2 participants