-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: Implement Python high level API in python #3938
python: Implement Python high level API in python #3938
Conversation
d7f6a8b
to
a9edaf6
Compare
3289b0c
to
5e6831f
Compare
5e6831f
to
41b1c6a
Compare
f96a6d7
to
4567114
Compare
42fb6ee
to
3c362bb
Compare
@dmitry-ganyushin ready for another round of review. I added pylint to the CI and I modify the code so that it satisfies most of the warnings, I disabled a few of them because since we use a C++ generated python module some of the checks do not work properly. |
c38260c
to
f69cb75
Compare
433f0ff
to
891d1ef
Compare
a48e149
to
73d2c37
Compare
@eisenhauer please review this 👼 |
I only have a little bit of time this morning and there are a lot of changes, so probably won't get through this until the evening, but will do what I can. |
Thanks! There has been several reviews from Scott (KW), Berk, and Dmitry, but I have made some changes since they reviewed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In py11Engine.cpp, MinBlocksInfo() returns a pointer, and if that pointer is non-null, the caller gains ownership to the created struct, so I think we need a delete of minBlocksInfo at the end of "if (minBlocksInfo)" in Engine::BlocksInfo.
73d2c37
to
ab3ab37
Compare
Good catch, find this resolved at the last push
…On Thu, Dec 28, 2023 at 5:21 PM Greg Eisenhauer ***@***.***> wrote:
***@***.**** requested changes on this pull request.
In py11Engine.cpp, MinBlocksInfo() returns a pointer, and if that pointer
is non-null, the caller gains ownership to the created struct, so I think
we need a delete of nBlocksInfo at the end of "if (mnBlocksInfo)" in
Engine::BlocksInfo.
—
Reply to this email directly, view it on GitHub
<#3938 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHFOFWZXDG4XISGXSIQKZDYLXWF3AVCNFSM6AAAAAA7VNKFSGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJYGQ3TINBWGA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
--
[image: logo shows large letter K with the word Kitware below it]
<http://www.kitware.com>
Vicente Bolea, MSc.
*Senior R&D Engineer*
|
|
Step of #3813
In this PR we move the implementation of File from C++/py11bind to pure Python. In addition to that we also add a High level python API that wraps the python bindings, this high level python API is needed to provide more pythonic supports and to connect the (File)Stream|FileReader with the other ADIOS2 objects (IO, adios, engine...)