-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request for adios_write to accept 'const void * var' #9
Comments
I would do this in a clean code. However, the adios_var_struct->data pointer is used for different things (read buffer in old adios_read, transformed variable instead of the original) and I am not able to safely separate them. This will stay open for a while... |
Thank you for looking into this. So are there any circumstances under which it is safe to assume that the data pointed to by var will not be modified by ADIOS? I'm not familiar with what adios_var_struct->data is and how it relates to the data I am passing in to adios_write, but I don't believe I have any variable transformations (I'm just dumping raw data), and I am only concerned with adios_write, not adios_read. If it is safe under those circumstances, then it saves the expense of my code allocating and copying into a temporary buffer. |
Ah yes, ADIOS does not touch the user data in adios_write() in any On Mon, May 12, 2014 at 11:50 AM, Andrew Corrigan
|
Just a thought, since adios_write is really just a wrapper function around
|
I am trying to get rid of the many compiler warnings, not to add new ones. On Mon, May 12, 2014 at 12:49 PM, daboyuka notifications@github.com wrote:
|
Definitely understandable. I'm fairly sure explicit casting never triggers
On Mon, May 12, 2014 at 1:00 PM, pnorbert notifications@github.com wrote:
|
This has been fixed in 1.9.0 |
Can adios_write please be modified to accept 'const void * var'? I assume that it is safe to do so, in which case it'd be preferable to have an explicit assurance that it is safe to assume the data pointed to by var is not modified.
The text was updated successfully, but these errors were encountered: