Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to use the reader from tifffile directly #289

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

KedoKudo
Copy link
Contributor

This PR switch the reader for tiff file from the dxchange wrapper to the one from tifffile directly.

IBM item: Story1209

@KedoKudo KedoKudo self-assigned this Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (11c4726) 94.92% compared to head (5979e28) 94.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #289   +/-   ##
=======================================
  Coverage   94.92%   94.92%           
=======================================
  Files          20       20           
  Lines        1201     1201           
=======================================
  Hits         1140     1140           
  Misses         61       61           
Impacted Files Coverage Δ
src/imars3d/backend/dataio/data.py 97.07% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change and the tests still pass

@KedoKudo KedoKudo merged commit 83953ce into next Apr 18, 2023
4 checks passed
@KedoKudo KedoKudo deleted the switch_tiff_reader_to_tifffile branch April 18, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants