Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent license in orocos_kdl/debian #330

Closed
ralph-lange opened this issue Apr 29, 2021 · 11 comments
Closed

Inconsistent license in orocos_kdl/debian #330

ralph-lange opened this issue Apr 29, 2021 · 11 comments

Comments

@ralph-lange
Copy link

According to orocos_kdl/COPYING and the headers of all source files (except issue #267) the library is licensed under LGPL.

The copyright file in the orocos_kdl/debian folder however states that the library is licensed under GPL. Could you clarify this, please?

@ralph-lange
Copy link
Author

Relates to #190.

@AndyZe
Copy link

AndyZe commented Jun 16, 2021

As I understand it, this matters because any project using Orocos/KDL inherits the restrictive GPL license. That's quite a few projects!

https://stackoverflow.com/a/1114054

@MatthijsBurgh
Copy link
Collaborator

@smits @meyerj

@smits
Copy link
Member

smits commented Jun 17, 2021

The copyright file in the orocos_kdl/debian folder however states that the library is licensed under GPL. Could you clarify this, please?

That should be updated, the correct license is LGPL.

@ralph-lange
Copy link
Author

Could you please also update orocos_kdl/tests/test-runner.cpp, cf. #267?

@MatthijsBurgh
Copy link
Collaborator

@ralph-lange could please apply the desired changes yourself and open a PR?

@ralph-lange
Copy link
Author

ralph-lange commented Jun 18, 2021

Such a contribution to a new repository involves not inconsiderable internal process work for me and would take several days. Moreover, changes to the copyright header should be made by the original author. The simplest thing would be if he simply removes lines 1 through 16 from https://github.com/orocos/orocos_kinematics_dynamics/blob/master/orocos_kdl/tests/test-runner.cpp. Then, the LGPL license from the parent folder applies.

@MatthijsBurgh
Copy link
Collaborator

I don't think the changes are that much.

It seems that you already did enough work to find out that the test runner is the only file that needs to be changed. So it wouldn't have been that much extra work. If other changes are needed, please open a PR or drop the line numbers in a new issue if you don't want to edit the lines yourself.

@ralph-lange
Copy link
Author

Thank you very much for resolving the issue in the test folder, @MatthijsBurgh. The issue in the debian folder can be resolved in the same way. If you can remove the copyright file there, the LGPL license from the parent folder will apply.

@MatthijsBurgh
Copy link
Collaborator

Changed the copyright in the debian folder to LGPL.

@ralph-lange
Copy link
Author

Thank you very much for resolving this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants