Support for multiple windows #17

orschiro · 2018-02-28T08:16:04Z

Should work with multiple windows too.

orschiro · 2018-03-04T13:09:14Z

@Bibernull I cleaned up the code in the recent commit to prepare for this issue.

Any idea how we could add support for switching between multiple windows?

yilinjuang · 2018-03-10T13:29:58Z

@orschiro i can think of two different ways of supporting multi-window.

users have global last tabs among all windows
users have independent last tabs for each window

Any ideas which is prefered?

orschiro · 2018-03-10T19:13:33Z

@frankyjuang in my opinion we should encourage people to maintain independent last tabs for each window and thus use windows to structure their work tasks. Accordingly, move a tab to the window where it belongs to if you want to switch between it.

Do you agree with me?

yilinjuang · 2018-03-11T08:40:08Z

Sounds really great for me. Will leave it until other bugs are solved.

orschiro · 2018-03-18T17:11:56Z

@frankyjuang currently testing the latest source in preparation of version 11.

However, the extension stops working after a while even in single window mode.

Can you please test too the latest commit?

yilinjuang · 2018-03-19T10:13:51Z

Really? Did you update to the HEAD? It works perfect for me after using couple of days with three windows. No error was logged. Or can you provide the logs from the background page console?

orschiro · 2018-03-19T12:46:49Z

Was able to capture this:

https://youtu.be/FJ0eQWhJCTY

yilinjuang · 2018-03-20T07:39:48Z

Can you set the log level to all levels (including verbose)? More debugging infos will then be displayed.

orschiro · 2018-03-20T14:24:43Z

@frankyjuang done. Does this produce any new insights?

https://youtu.be/-ThiBZ_09-k

yilinjuang · 2018-03-20T15:38:01Z

@orschiro I really can't tell....the error just came from nowhere.
Add this line right at the beginning of function removeTabFromWindow (Ln. 130).

console.warn(windows, windowId, tabId, currentTabId);

and see what it says when the mystery occurs.

orschiro · 2018-03-21T09:03:41Z

Hope it helps!

Screencast: https://youtu.be/EFYwx-vlv04

yilinjuang · 2018-03-24T05:27:38Z

Really weird...It seems that when you open a new tab in the background at 0:55, a onActivated event is triggered on the same page. How did you open the new tab in the background? I saw a cute image popup. Did you use some extensions that might related to this behavior?

Btw, my guess about glitch due to tab removal is wrong. The extra console.warn is totally useless 😭
This time please add it right at the beginning of function chrome.browserAction.onClicked.addListener.

console.warn(windows, currentWindowId, tab, currentTabId);

Let's see what we can do about this mystery...

orschiro · 2018-03-24T10:38:05Z

I saw a cute image popup. Did you use some extensions that might related to this behavior?

Good catch!

Will test if it conflicts with:

These two I am using that my interfere here. Will let you know!

orschiro · 2018-03-24T10:44:15Z

New screencast: https://youtu.be/H4cTBfCgoD4

yilinjuang · 2018-03-24T14:16:32Z

I think I kind of know what happened. It's about the behavior of window manager. According to chrome.windows.onFocusChanged,

Fired when the currently focused window changes. Will be chrome.windows.WINDOW_ID_NONE if all chrome windows have lost focus. Note: On some Linux window managers, WINDOW_ID_NONE will always be sent immediately preceding a switch from one chrome window to another.

reference

What you encountered is that the window manager seemed to switch to a non-chrome window but never switch back...That's why you see the Object -1 Object null. -1 means id of non-chrome window. null is the currentTabId if focusing on non-chrome window. And since it is all about window manager, I'm not having the same issue on macOS.

Which window manager are you using? The default one of GNOME 3? Mutter? Perhaps we should search for similar issues?

orschiro · 2018-03-24T15:06:20Z

Well done! Yes I'm using GNOME Shell 3.26 with Mutter on Fedora 27. Going to search the bug tracker of Chromium.

…

On Sat, Mar 24, 2018, 15:16 Juang, Yi-Lin ***@***.***> wrote: I think I kind of know what happened. It's about the behavior of window manager. According to chrome.windows.onFocusChanged, Fired when the currently focused window changes. Will be chrome.windows.WINDOW_ID_NONE if all chrome windows have lost focus. Note: On some Linux window managers, WINDOW_ID_NONE will always be sent immediately preceding a switch from one chrome window to another. reference <https://developer.chrome.com/extensions/windows#event-onFocusChanged> What you encountered is that the window manager seemed to switch to a non-chrome window but never switch back...That's why you see the Object -1 Object null. -1 means id of non-chrome window. null is the currentTabId if focusing on non-chrome window. And since it is all about window manager, I'm not having the same issue on macOS. Which window manager are you using? The default one of GNOME 3? Mutter? Perhaps we should search for similar issues? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKbw9A6i-JcouSNX8DJSH37Ez36vkPsks5thlVAgaJpZM4SWPX6> .

orschiro · 2018-03-25T13:55:45Z

Ref: https://gitlab.gnome.org/GNOME/gnome-shell/issues/151

orschiro · 2018-03-26T09:10:46Z

@frankyjuang meanwhile, how about we add a new setting to context menu for people to opt in to multiple window support? Would be disabled by default. This way people on non-Linux can already test and benefit.

yilinjuang · 2018-03-26T16:19:02Z

This could be a short-term fix. But eventually I think multi-window support should be turned on by default.

yilinjuang · 2018-04-03T15:54:07Z

Any updates here?

orschiro · 2018-04-03T18:45:29Z

Unfortunately haven't heard back from the GNOME devs.

I guess next step is testing with non GNOME Linux environments and see if they are also affected.

orschiro · 2018-04-12T09:45:32Z

@frankyjuang did some tests with GNOME 3.28 but couldn't get latest commit to work. As soon as I load unpacked, it's breaking:

Not sure how to fix this or how to proceed.

yilinjuang · 2018-04-29T07:34:00Z

@orschiro which chrome version are you using? I cannot reproduce on latest GNOME.

orschiro · 2018-04-30T17:04:21Z

@frankyjuang tested with a brand new Chrome 66 profile and latest git pull. Loaded unpacked from src but still getting this annoying tabHistory error. Are you doing anything differently?

Error in event handler for browserAction.onClicked: TypeError: Cannot read property 'tabHistory' of undefined
    at <URL>
_generated_background_page.html:1 Error in event handler for browserAction.onClicked: TypeError: Cannot read property 'tabHistory' of undefined
    at chrome-extension://ackkikfiigagnmobecoofdoaffneiadl/background.js:65:41

yilinjuang · 2018-05-03T05:35:14Z

As far as I know, no. Same setup but no such error.

orschiro · 2018-05-04T07:36:51Z

Version 11 Multiple Windows has been published. Let's wait for some more user feedback! :-)

orschiro · 2018-05-07T12:26:22Z

@frankyjuang reinstalled version 11.1 from Chrome Webstore and it breaks: https://chrome.google.com/webstore/detail/switch-recent-tabs/odhjcgnlbagjllfbilicalpigimhdcll

A number of people report similar issues:

See Maciej
See also Support page

orschiro · 2018-05-07T12:45:22Z

For a temporary downgrade, see: https://github.com/orschiro/switch-recent-tabs-chrome-extension/wiki/FAQ#temporarily-downgrade

amorpheus · 2018-05-07T14:33:15Z

My issue is that the extension will work normally after starting Chrome, but not for long. I only work with one window. After coming back to Chrome from other programs, there's no Last Tab functionality at all. If I open a new Chrome window and close it again, I can get the extension to shortly work sometimes, but I haven't been able to pin down the exact behavior.

Running Windows 10 Enterprise (Build 1703) on a Xeon E3 1230-v3 with 16GB RAM.

yilinjuang · 2018-05-07T14:52:45Z

@amorpheus can you confirm if it only happens after switching to and back from other programs? and does it occurs right after switching back? thanks

amorpheus · 2018-05-07T15:11:30Z

Okay, I went through it again. Here's what I observed:

completely close Chrome including task bar icon (background task)
start Chrome, extension works normally
switch focus to another program (I just clicked the Windows task bar)
focus back to Chrome, immediately hit Ctrl-Q as I've set it, extension often works once, sometimes twice or not at all

My take is that it seems to be functional for only a short interval after switching back to a Chrome window.

orschiro · 2018-05-07T15:18:50Z

@amorpheus can you check if you get the error in the console shown here: #17 (comment)

amorpheus · 2018-05-07T15:24:33Z

Just opening the developer console with F12? I'm not seeing that there. Just some "Failed to load" messages, presumably from adblock.

orschiro · 2018-05-07T15:26:12Z

@amorpheus do a right mouse click on the extension icon > manage extension > background page

Actually great observation! I can confirm that switching app windows breaks it after a few seconds of returning to Chrome.

@frankyjuang any ideas why this is happening and apparently only on Windows and Linux?

amorpheus · 2018-05-07T15:28:45Z

Alright, I see the same error as in the screenshot now.

sxhexe · 2018-05-07T17:52:04Z

I can confirm seeing the same error as in the screenshot .

Here's my screenshot. I'm on Windows 10, Chrome Version 66.0.3359.139 (Official Build) (64-bit).

The behavior I see is whenever you switch to a different App (can even be another Chrome window) and switch back, Alt+Q will have an effect for once, and it always goes to the same tab (that might have been set at some point). After that Alt+Q doesn't do anything.

eljejer · 2018-05-08T07:55:54Z

Trying to debug Alt Q not working. There seems to be no error in the backgroundpage (screenshot)

orschiro · 2018-05-08T07:57:19Z

Thanks for all your help! I have released a temporary release 12 that reverts the changes and should work stability for you until we have solved this issue. You should get the latest version in a few minutes.

orschiro · 2018-05-09T17:15:02Z

Here are some more debug infos from people who had troubles:

Client version: 5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Client version: 5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Client version: 5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Client version: 5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Client version: 5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Client version: 5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

Client version: 5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36

orschiro · 2018-05-14T12:34:38Z

User feedback.

Multiple window support should become optional, i.e. implemented with a context menu option. :-)

orschiro added the enhancement label Feb 28, 2018

orschiro self-assigned this Feb 28, 2018

orschiro added help-wanted and removed enhancement labels Mar 4, 2018

orschiro added the enhancement label Mar 8, 2018

orschiro mentioned this issue Mar 8, 2018

Deprecated Chrome APIs #21

Closed

orschiro added discussion and removed help-wanted labels Mar 10, 2018

yilinjuang self-assigned this Mar 13, 2018

yilinjuang mentioned this issue Mar 14, 2018

Support multiple windows #31

Merged

orschiro added testing and removed discussion enhancement labels Mar 17, 2018

yilinjuang mentioned this issue Mar 25, 2018

Weird tab behaviour if once switch to other windows #24

Closed

orschiro mentioned this issue May 7, 2018

It does not work now after the auto update #37

Closed

orschiro added enhancement and removed testing labels Jul 13, 2018

orschiro closed this as completed Oct 2, 2018

Support for multiple windows #17

Support for multiple windows #17

Comments

orschiro commented Feb 28, 2018

orschiro commented Mar 4, 2018

yilinjuang commented Mar 10, 2018

orschiro commented Mar 10, 2018

yilinjuang commented Mar 11, 2018

orschiro commented Mar 18, 2018

yilinjuang commented Mar 19, 2018

orschiro commented Mar 19, 2018

yilinjuang commented Mar 20, 2018

orschiro commented Mar 20, 2018

yilinjuang commented Mar 20, 2018

orschiro commented Mar 21, 2018

yilinjuang commented Mar 24, 2018

orschiro commented Mar 24, 2018

orschiro commented Mar 24, 2018

yilinjuang commented Mar 24, 2018

orschiro commented Mar 24, 2018 via email

orschiro commented Mar 25, 2018

orschiro commented Mar 26, 2018

yilinjuang commented Mar 26, 2018

yilinjuang commented Apr 3, 2018

orschiro commented Apr 3, 2018

orschiro commented Apr 12, 2018

yilinjuang commented Apr 29, 2018

orschiro commented Apr 30, 2018

yilinjuang commented May 3, 2018

orschiro commented May 4, 2018

orschiro commented May 7, 2018

orschiro commented May 7, 2018

amorpheus commented May 7, 2018 • edited Loading

yilinjuang commented May 7, 2018

amorpheus commented May 7, 2018

orschiro commented May 7, 2018

amorpheus commented May 7, 2018 • edited Loading

orschiro commented May 7, 2018

amorpheus commented May 7, 2018

sxhexe commented May 7, 2018 • edited Loading

eljejer commented May 8, 2018

orschiro commented May 8, 2018

orschiro commented May 9, 2018

orschiro commented May 14, 2018

amorpheus commented May 7, 2018 •

edited

Loading

amorpheus commented May 7, 2018 •

edited

Loading

sxhexe commented May 7, 2018 •

edited

Loading