Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a horizontal ORStackView #10

Closed
dblock opened this issue Apr 2, 2014 · 8 comments
Closed

Create a horizontal ORStackView #10

dblock opened this issue Apr 2, 2014 · 8 comments

Comments

@dblock
Copy link
Contributor

dblock commented Apr 2, 2014

I'd like to stack things horizontally. That's a bit of an oxymoron, "stack" horizontally.

@orta
Copy link
Owner

orta commented Apr 2, 2014

android debs are totally into it: http://developer.android.com/reference/android/widget/StackView.html

@delebedev
Copy link
Contributor

I want to take this one. At first I thought to keep it simple and just introduce direction property, but there are methods in public API that explicitly say about used direction (like addSubview:withTopMargin or insertSubview:belowSubview), logical output of this observation is to

  • have shared internal class GenericStackView and two sibilings ORStackView and ORHorizontalStackView.
  • try to avoid base class and use some composition here.
    @orta what do you think?

@dblock
Copy link
Contributor Author

dblock commented Apr 20, 2015

@garnett 👍

@orta
Copy link
Owner

orta commented Apr 20, 2015

I think that's a good way to do it @garnett 👍 - please ensure it has tests too

@delebedev
Copy link
Contributor

@orta but which one of the two I've described? 😄

@orta
Copy link
Owner

orta commented Apr 20, 2015

Hah - sorry, I originally thought about the internal class, but I think I'm more open to the composition.

The biggest problem lies in that ORTagBasedAutoStackView ideally would want to fit in this too. Perhaps there could be a base class that has a layout class like structure. Similar in metaphor to UICollectionView with the UICollectionViewLayout object?

@delebedev
Copy link
Contributor

Yes that makes sense, I will think about it and update the ticket with high level concept.

@orta orta mentioned this issue Apr 22, 2015
@orta
Copy link
Owner

orta commented May 5, 2015

👍

@orta orta closed this as completed May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants