-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keys for multiple targets #72
Comments
I tried placing each |
We ( Artsy) don't have any projects that use multiple targets, so I'm afraid right now that is totally untested, probably wouldn't be too hard to support though - the codebase is pretty small. |
Why do you think the second call to the plugin removes what was done by the first call? |
You can only have one |
@segiddins Ah, thanks, so then would the proper fix be to allow the |
Also, if I wanted to take a look at fixing this, what's the easiest way to switch to using a local clone from CocoaPods for debugging? I'm not familiar enough with Ruby or Gems to configure that. |
You want to use a Gemfile - you can then use You can only give a plugin a hash/dictionary, so it might make sense to do something like:
|
I've gotten something working now, using a list of target names. I'll submit a pull request once I'm comfortable with it. The solution requires all targets to share a list of keys, which should be fine, and allowed for a simple implementation. Thanks for the help getting up and running. The Podfile plugin call looks like this:
|
Yeah, do it! ( If you can make |
I have it working for strings and arrays inside |
It shouldn't |
I updated the pull request to pass the build |
…added a suite of test cases for it (Issue orta#72)
… Travis and wasn't necessary (Issue orta#72)
I added specs for the new code |
Fixed 👍 |
This does not work for nested test targets as described in the Cocoapod's Podfile documentation. Output of
|
You're welcome to take a look at fixing this 👍 |
Sounds good @orta. I will start tackling this tomorrow. Would you prefer that I open a new issue? Or continue by link relevant comments/code here? |
New please :) |
Hi, Thanks for this awesome Pod. I am facing the same issue that @loudmouth faced. Could not find a target named 'TEST_TARGET_NAME' in your Podfile. Stopping keys This is how my PodFile Looks like:- abstract_target 'AbstractPod' do
endCan you help me with this? |
These tests are currently crashing. I think I should just delete these tests, but I'll spend a bit more time on this. I'm not currently using these tests to the full extent because it seems difficult to get it all setup with external libraries. Reason for the crash: I need to install the relevant libraries in the Podfile for WiltUITests. Cocoapods-keys doesn't support multiple targets with the same keys, which makes it unworkable. Relevant issue: orta/cocoapods-keys#72
I use API keys in files that are parts of different targets in my app. It's not totally clear how to do this, so I tried having the following in my Podfile:
This way, the last one wins, and my
AppTarget
doesn't get linked against the generated Keys project. Any ideas?The text was updated successfully, but these errors were encountered: