Patch rubocop #173
Merged
Patch rubocop #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ykws - we really need to keep ruby 2.0 support around - any chance you can add |
|
@orta Thank you for the review. I tried it. |
orta
reviewed
Jun 29, 2017
lib/keyring_liberator.rb
Outdated
| @@ -63,7 +63,7 @@ def self.get_all_keyrings | |||
| end | |||
|
|
|||
| def self.get_keyring_at_path(path) | |||
| Keyring.from_hash(YAML.load(path.read)) if path.file? | |||
| Keyring.from_hash(YAML.safe_load(path.read)) if path.file? | |||
There was a problem hiding this comment.
any chance you can check for YAML.safe_load's existence before using it? in the CI it doesn't seem to exist (could be a ruby 2.0 thing )
There was a problem hiding this comment.
sorry. my local ruby was 2.4 . I changed it to ruby 2.0 and retry bundle exec rake spec and succeeded.
|
Amazing! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #172