Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyword argument like ERB.new(str, trim_mode: ...) instead #233

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

wata
Copy link
Contributor

@wata wata commented Nov 4, 2022

Fix #229

I fixed these two warnings

  • Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
  • Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

@orta
Copy link
Owner

orta commented Nov 4, 2022

It's been a long time since I've written Ruby, can you just clarify that this syntax doesn't affect backwards compatability?

@orta
Copy link
Owner

orta commented Dec 6, 2022

well, lets just see how it goes then

@orta orta merged commit 8bdb029 into orta:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERB.new is deprecated
2 participants