Add support for Ventura and M1 | osx_keychain to ruby-keychain #235
Conversation
|
Looks pretty solid to me, there's no tests on this repo so maybe just give it a run in your own app a bit to verify 👍🏻 |
|
@orta yes that's why its in draft I still need to test on some intel machines and m1 machines with keychains generated with the osx_keychain. |
|
Just tested with intel. Clean install and on an older cocoapods version. Working perfectly so also with existing secrets! :) I just had a tiny dependency issue before. Who wants to test this can install this into your project's Gemfile: |
|
Greeat! |
|
Thanks, this is deployed as 2.3.0! |
| item.password = value | ||
| item.save! | ||
| else | ||
| keychain_has_keykeychain.create(service: self.class.keychain_prefix + name, password: value, account: key) |
There was a problem hiding this comment.
I get error here on adding new key-value pair:
NameError - undefined local variable or method keychain_has_keykeychain
Fix looks simple:
keychain_has_keykeychain.create -> keychain.create
There was a problem hiding this comment.
@RomanDashchakivskyi-TomTom please checkout: #236 is fixed there :)
I rewrote the
keychain.rbfile to use the ruby keychain plugin, which works also on m1 machines. And removes the broken dependency on ruby_inline.What has been done:
• Updated dependencies (and ruby to 2.7.4 native m1 supported)
• Updated rubocop
• Moved keychain.rb logic from osx_keychain to ruby_keychain
• Updated tests