Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown with triggers on mobile res doesnt show modal correctly #609

Closed
Diogo-Coding opened this issue Oct 4, 2023 · 1 comment · Fixed by #615
Closed

Dropdown with triggers on mobile res doesnt show modal correctly #609

Diogo-Coding opened this issue Oct 4, 2023 · 1 comment · Fixed by #615
Assignees
Labels
bug Something isn't working refactoring This involves some refactoring of existing code.

Comments

@Diogo-Coding
Copy link

Overview of the problem

Oruga version: [0.7.0]
Oruga Bulma version: [0.2.11]
Vuejs version: [3.2.13]
OS/Browser: Chrome

Description

Adding ":triggers="['hover', 'focus', 'click']" to the dropdown component options makes it show incorrectly for mobile screens the modal with the options

if you remove the triggers prop it will show correctly

Steps to reproduce

  1. Add/Remove :triggers="['hover', 'focus','click']"
@mlmoravek mlmoravek added the bug Something isn't working label Oct 5, 2023
@mlmoravek
Copy link
Member

I think this is because the mobileClass is not applied if it is hoverable.

{
    [this.computedClass("mobileClass", "o-drop--mobile")]:  
       this.isMobileModal &&  
       this.isMatchMedia &&  
       !this.hoverable,  
},

soruce link

To me, a better solution would be to drop the 'hover' trigger if the client is a mobile agent (not just a small screen) and react the same as the 'click' trigger on a mobile agent.

@jtommy What do you think?

mlmoravek added a commit to mlmoravek/oruga that referenced this issue Oct 5, 2023
@mlmoravek mlmoravek self-assigned this Oct 5, 2023
@mlmoravek mlmoravek added the refactoring This involves some refactoring of existing code. label Oct 5, 2023
mlmoravek added a commit to mlmoravek/oruga that referenced this issue Oct 8, 2023
jtommy pushed a commit that referenced this issue Oct 10, 2023
* feat: update programmatic oruga

* fix: type error

* revert: vue update

* docs: update

* revert: vue update

* fix: typo

* fix: useOruga bug

* reafactor: update input components

* reafactor: update dropdown components

* refactor: dropdown active prop

* udpate: emit docs

* revert: dropdown generics

* fix: remove unnecessary dependency

* update: dropdown modelValue

* fix: dropdown hover mobilenative #609

* revert: vue update

* docs: update

* revert: vue update

* reafactor: update input components

* fix: dropdown hover mobilenative #609

* fix: merge fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants