Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug dropdown hover on mobile agent #615

Merged
merged 24 commits into from
Oct 10, 2023

Conversation

mlmoravek
Copy link
Member

Proposed fix for hover not working on mobile agents.

Fixes #609

Proposed Changes

  • drop the 'hover' trigger if the client is a mobile agent (not just a small screen) and react the same as the 'click' trigger on a mobile agent.

@mlmoravek mlmoravek added the bug Something isn't working label Oct 7, 2023
@mlmoravek mlmoravek self-assigned this Oct 7, 2023
@netlify
Copy link

netlify bot commented Oct 7, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 042f676
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6523af61d5152500070f8bc5
😎 Deploy Preview https://deploy-preview-615--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3cc401a) 63.93% compared to head (042f676) 63.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #615      +/-   ##
===========================================
- Coverage    63.93%   63.91%   -0.02%     
===========================================
  Files           86       86              
  Lines         5593     5593              
  Branches      1590     1590              
===========================================
- Hits          3576     3575       -1     
- Misses        1906     1907       +1     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 55.39% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtommy jtommy merged commit 4a5c0ab into oruga-ui:develop Oct 10, 2023
9 of 11 checks passed
@mlmoravek mlmoravek deleted the bug-dropdown-mobile-agent branch October 11, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown with triggers on mobile res doesnt show modal correctly
2 participants