Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): icon pack bug #628

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(icon): icon pack bug #628

merged 1 commit into from
Oct 17, 2023

Conversation

mlmoravek
Copy link
Member

Fix docs icon pack bug

@mlmoravek mlmoravek added the bug Something isn't working label Oct 17, 2023
@mlmoravek mlmoravek self-assigned this Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 937a080
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/652e30bc83c3000008fd1de7
😎 Deploy Preview https://deploy-preview-628--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (fd7f324) 62.86% compared to head (937a080) 62.64%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #628      +/-   ##
===========================================
- Coverage    62.86%   62.64%   -0.22%     
===========================================
  Files           87       87              
  Lines         5587     5598      +11     
  Branches      1590     1595       +5     
===========================================
- Hits          3512     3507       -5     
- Misses        1964     1980      +16     
  Partials       111      111              
Flag Coverage Δ
oruga 65.92% <ø> (ø)
oruga-next 48.78% <8.82%> (-0.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/oruga-next/src/components/icon/Icon.vue 63.88% <ø> (ø)
packages/oruga-next/src/utils/icons.ts 100.00% <100.00%> (+9.09%) ⬆️
...ages/oruga-next/src/composables/useProgrammatic.ts 0.00% <0.00%> (ø)
...es/oruga-next/src/composables/useParentProvider.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtommy jtommy merged commit 922f880 into oruga-ui:develop Oct 17, 2023
8 of 11 checks passed
@mlmoravek mlmoravek deleted the fix-icons branch October 17, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants