Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(slider): update api #645

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Oct 26, 2023

This is part of #606

In this pull request I refactored the slider component from Options-API to Composition-API.

Proposed Changes

  • Update Sliderto composition api
  • Update docs
  • Add disabled prop to tooltip
  • Remove unused files

@mlmoravek mlmoravek added the refactoring This involves some refactoring of existing code. label Oct 26, 2023
@mlmoravek mlmoravek self-assigned this Oct 26, 2023
@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 63e19ac
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/653a3c0a6bcbda0008fd0b78
😎 Deploy Preview https://deploy-preview-645--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek added the enhancement Improvements to existing features and functionality label Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (267313a) 59.03% compared to head (63e19ac) 59.03%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #645   +/-   ##
========================================
  Coverage    59.03%   59.03%           
========================================
  Files           87       87           
  Lines         2429     2429           
  Branches       814      814           
========================================
  Hits          1434     1434           
  Misses         884      884           
  Partials       111      111           
Flag Coverage Δ
oruga 67.21% <ø> (ø)
oruga-next 48.89% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...es/oruga-next/src/composables/useParentProvider.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 8772f7a into oruga-ui:develop Oct 26, 2023
9 of 11 checks passed
@mlmoravek mlmoravek deleted the refactor-slider branch October 26, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features and functionality refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant