Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup #651

Merged
merged 32 commits into from
Oct 30, 2023
Merged

refactor: cleanup #651

merged 32 commits into from
Oct 30, 2023

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Oct 30, 2023

Last cleanup for the switch to composition api.

Fixes #606

Proposed Changes

  • Updated several slot/prop descriptions
  • Add code comments
  • Extract programmatic functional to specific files
  • Add associated type definition files
  • Remove unused files

@mlmoravek mlmoravek self-assigned this Oct 30, 2023
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit 37711e5
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/653f7e0498f66a0007e8fb3a
😎 Deploy Preview https://deploy-preview-651--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek mlmoravek added the refactoring This involves some refactoring of existing code. label Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (239ad99) 58.77% compared to head (37711e5) 58.45%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #651      +/-   ##
===========================================
- Coverage    58.77%   58.45%   -0.32%     
===========================================
  Files           87       89       +2     
  Lines         2428     2448      +20     
  Branches       818      819       +1     
===========================================
+ Hits          1427     1431       +4     
- Misses         890      906      +16     
  Partials       111      111              
Flag Coverage Δ
oruga 67.21% <ø> (ø)
oruga-next 47.77% <47.05%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/oruga-next/src/components/button/Button.vue 82.60% <ø> (ø)
...es/oruga-next/src/components/checkbox/Checkbox.vue 86.36% <ø> (ø)
...es/oruga-next/src/components/collapse/Collapse.vue 100.00% <ø> (ø)
...ckages/oruga-next/src/composables/useClassProps.ts 100.00% <100.00%> (ø)
packages/oruga-next/src/utils/config.ts 62.50% <ø> (+1.38%) ⬆️
packages/oruga-next/src/components/field/Field.vue 78.12% <0.00%> (-1.88%) ⬇️
packages/oruga-next/src/utils/helpers.ts 11.62% <0.00%> (ø)
packages/oruga-next/src/utils/plugins.ts 26.66% <33.33%> (ø)
...-next/src/components/autocomplete/Autocomplete.vue 53.99% <60.00%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek marked this pull request as ready for review October 30, 2023 09:30
@mlmoravek mlmoravek merged commit 3df516b into oruga-ui:develop Oct 30, 2023
8 of 11 checks passed
@mlmoravek mlmoravek deleted the cleanup branch October 30, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Use Composition API
1 participant