Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: enhance a11y & add vuejs-accessibility lint rule #723

Closed

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Jan 5, 2024

Fixes #596
Fixes #446

Proposed Changes

TODO:

  • testing

# Conflicts:
#	.npmrc
#	packages/oruga-next/.eslintrc.cjs
#	packages/oruga-next/package-lock.json
#	packages/oruga-next/package.json
#	packages/oruga-next/src/components/datepicker/DatepickerTableRow.vue
#	packages/oruga-next/src/components/input/Input.vue
#	packages/oruga-next/src/shims-vue.d.ts
#	packages/oruga-next/vite.config.ts
# Conflicts:
#	packages/oruga-next/.eslintrc.cjs
#	packages/oruga-next/package.json
# Conflicts:
#	packages/oruga-next/package-lock.json
#	packages/oruga-next/package.json
#	packages/oruga-next/src/components/checkbox/Checkbox.vue
#	packages/oruga-next/src/components/datetimepicker/Datetimepicker.vue
#	packages/oruga-next/src/components/field/FieldBody.vue
#	packages/oruga-next/src/components/loading/Loading.vue
#	packages/oruga-next/src/components/loading/index.ts
#	packages/oruga-next/src/components/modal/Modal.vue
#	packages/oruga-next/src/components/modal/index.ts
#	packages/oruga-next/src/components/notification/index.ts
#	packages/oruga-next/src/components/sidebar/Sidebar.vue
#	packages/oruga-next/src/components/skeleton/Skeleton.vue
#	packages/oruga-next/src/utils/FormElementMixin.ts
#	packages/oruga-next/src/utils/NoticeMixin.ts
#	packages/oruga-next/src/utils/TimepickerMixin.ts
#	packages/oruga-next/src/utils/helpers.ts
# Conflicts:
#	packages/oruga-next/package-lock.json
#	packages/oruga-next/package.json
@mlmoravek mlmoravek added the enhancement Improvements to existing features and functionality label Jan 5, 2024
@mlmoravek mlmoravek added the a11y Accessibility label Jan 5, 2024
@mlmoravek mlmoravek self-assigned this Jan 5, 2024
Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for oruga-documentation-preview failed.

Name Link
🔨 Latest commit d3b2304
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65ce243dcc673e00088e52b7

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (da9eb0f) 54.32% compared to head (f00181d) 55.04%.
Report is 1 commits behind head on develop.

❗ Current head f00181d differs from pull request most recent head d3b2304. Consider uploading reports for the commit d3b2304 to get more accurate results

Files Patch % Lines
packages/oruga-next/src/components/input/Input.vue 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #723      +/-   ##
===========================================
+ Coverage    54.32%   55.04%   +0.72%     
===========================================
  Files           31       32       +1     
  Lines         1493     1466      -27     
  Branches       530      522       -8     
===========================================
- Hits           811      807       -4     
+ Misses         682      659      -23     
Flag Coverage Δ
oruga-next 55.04% <87.50%> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Enhance a11y Tab Component: Improve Accessibility
1 participant