Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab Component: Improve Accessibility #446

Closed
mlmoravek opened this issue Nov 15, 2022 · 3 comments · Fixed by #762
Closed

Tab Component: Improve Accessibility #446

mlmoravek opened this issue Nov 15, 2022 · 3 comments · Fixed by #762
Assignees
@mlmoravek
Labels
a11y Accessibility enhancement Improvements to existing features and functionality good first issue Good for newcomers

Comments

@mlmoravek
Copy link
Member

Description

Currently the tabs of the Tab Component can't reached by keyboard tabs by default.

This can be solved by adding tabindex="0" to the TabsItem Component.
Furthermore, the TabItem could also additionally get role="button" to get the HTML element appear as a button to screen readers.

Why Oruga need this feature

Improve Accessibility
@jtommy
Copy link
Member

jtommy commented Nov 26, 2022

@mlmoravek would you like to work on it?

@jtommy jtommy added the good first issue Good for newcomers label Nov 26, 2022
jtommy added a commit that referenced this issue Nov 26, 2022
@jtommy
feat(tabs): #446 set tabindex=0 on active tab
b0e0d0a
@mlmoravek
Copy link
Member Author

@jtommy I just had time to look at your implementation. You misunderstood the issue. You added the tabindex="0" to the div in the "nav-content" section element. But it should be on the "nav-item" div element to change the active tab by keyboard.

@astagi
Copy link
Member

astagi commented Jan 20, 2023

Thanks for your review @mlmoravek will work to improve a11y following your suggestions

@astagi astagi added enhancement Improvements to existing features and functionality a11y Accessibility labels Jan 20, 2023
@jtommy jtommy assigned mlmoravek and unassigned jtommy Oct 15, 2023
@mlmoravek mlmoravek mentioned this issue Jan 9, 2024
Closed
@mlmoravek mlmoravek mentioned this issue Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlmoravek mlmoravek

Labels
a11y Accessibility enhancement Improvements to existing features and functionality good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@astagi @jtommy @mlmoravek