feat(swr): support for using fetch for http clients with swr
#1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
follow up #1387
I added
output.httpClientoption.And able to using
fetchAPI withswrclient. custom mutators also available.Since
@orval/fetchdoesn't have a any deps, i specified@orval/fetchas a dependency of@orval/swr. This allows the automatically generated functions of the http client to be shared, improving maintainability.Related PRs
none
Todos
Steps to Test or Reproduce
You can check generated code in the test
cd tests yarn generateI added test case is bellow:
generated/swr/http-client-fetchgenerated/swr/http-client-fetch